net-im/spectrum2: New package #7815

ConiKost · 2018-04-04T22:11:19Z

net-im/spectrum2: New package

Closes: https://bugs.gentoo.org/291437

gentoo-repo-qa-bot · 2018-04-04T22:13:02Z

Pull Request assignment

Areas affected: ebuilds
Packages affected: net-im/spectrum2

net-im/spectrum2: @gentoo/proxy-maint (new package)

Bugs linked: 291437

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Dessa · 2018-04-04T23:36:39Z

i have a question since im still using my own version from my overlay: does this still suffer of the massive overlinking due to swiften-config?
spectrum2 essentially links against everything libSwiften does and as such causes needless rebuilds (at least it did for me for ICU)

ConiKost · 2018-04-05T07:42:42Z

does this still suffer of the massive overlinking due to swiften-config?

Yes, I do also have this observed. Seems to be still the case.

Package-Manager: Portage-2.3.31, Repoman-2.3.9

Package-Manager: Portage-2.3.31, Repoman-2.3.9 Closes: gentoo#8127

…able in favour of 3.3.3 stable Package-Manager: Portage-2.3.31, Repoman-2.3.9 Closes: gentoo#8126

Package-Manager: Portage[mgorny]-2.3.26.1 Closes: gentoo#8015

Signed-off-by: Anthony G. Basile <blueness@gentoo.org>

…ORE-2018-004. Package-Manager: Portage-2.3.24, Repoman-2.3.6

Package-Manager: Portage-2.3.31, Repoman-2.3.9

Many notable changes: 1. Drop python and lua. Bindings are no longer bundled with LXC and live in separate packages. 2. Drop cgmanager USE flag. cgmanager isn't supported anymore by upstream. 3. Remove versionator inherit. It wasn't used. 4. Remove two patches which were simple cherry pick from upstreams. They're applied upstream now. 5. Remove notice about path change in v1.1. It's been a while, it lost relevance. 6. Remove start-ephemeral bash completion. Upstream finally removed it from its own completions. 7. Add "pam" USE flag for the compilation and installation of the new builtin "pam_cgfs.so" module. Closes: https://bugs.gentoo.org/652582 Closes: gentoo#7934 Package-Manager: Portage-2.3.24, Repoman-2.3.6 Signed-off-by: Matthias Maier <tamiko@gentoo.org>

Package-Manager: Portage-2.3.31, Repoman-2.3.9

Package-Manager: Portage-2.3.27, Repoman-2.3.9

Package-Manager: Portage-2.3.31, Repoman-2.3.9

Overshadowed by 2.00.x, no reverse deps. Package-Manager: Portage-2.3.31, Repoman-2.3.9

Reported-by: putty_bug@online.de Closes: https://bugs.gentoo.org/651816 Package-Manager: Portage-2.3.31, Repoman-2.3.9

EAPI 6. Package-Manager: Portage-2.3.31, Repoman-2.3.9

Package-Manager: Portage-2.3.31, Repoman-2.3.9

mgorny · 2018-04-29T07:51:08Z

net-im/spectrum2/files/spectrum2.initd

@@ -0,0 +1,40 @@
+#!/sbin/openrc-run


Please modernize this:

Use command etc. to avoid redundant phases.

Use checkpath to create directories.

i'm not seeing the first change though.

Because I misunderstood this. I see now, whats meant by command.
I've updated the script, but there is one thing, I miss. I can't set the args based on start or stop.
So I had to keep the stop function. Is there a better way?

mgorny · 2018-04-29T07:51:25Z

net-im/spectrum2/spectrum2-2.0.6.ebuild

+IUSE="debug doc frotz irc mysql postgres purple sms sqlite test twitter xmpp"
+REQUIRED_USE="|| ( mysql postgres sqlite )"
+
+DEPEND="dev-libs/boost


mgorny · 2018-04-29T07:51:38Z

net-im/spectrum2/spectrum2-2.0.6.ebuild

+
+DEPEND="dev-libs/boost
+	dev-libs/expat
+	dev-libs/libxml2


Why does it use two different XML libraries?

I am not sure, I see both are used, if found by CMakeLists.txt. ldd confirms linked against both.
But it also works, if linked against only one of them. I made a new use flag expat.

Please investigate the code. It may indeed need only one of them but accidentally link to both. But it may also have independent features that use either (e.g. some old code using expat and new code using libxml2, or the other way around).

Hm, hard to say. I don't see any references. I see, that in CMakeLists.txt always includes expat and libxml2, if available. But: Running lddtree on the compiles binaries, I can clearly see, only expat is linked, libxml2 not, even when installed. On the other hand, the official debian package depends on libxml2-dev.. any ideas?

mgorny · 2018-04-29T07:51:47Z

net-im/spectrum2/spectrum2-2.0.6.ebuild

+	dev-libs/expat
+	dev-libs/libxml2
+	dev-libs/log4cxx
+	dev-libs/jsoncpp


mgorny · 2018-04-29T07:51:59Z

net-im/spectrum2/spectrum2-2.0.6.ebuild

+	dev-libs/jsoncpp
+	dev-libs/openssl:0=
+	dev-libs/popt
+	dev-libs/protobuf


mgorny · 2018-04-29T07:52:36Z

net-im/spectrum2/spectrum2-2.0.6.ebuild

+
+src_configure() {
+	if use debug; then
+		CMAKE_BUILD_TYPE="Debug"


What does it do?

According to the Readme, Debug enables debugging symbols.

Please check if that means -g* flags. If it does, please remove the flag since we do that via altering CFLAGS directly whenever necessary. USE=debug is for things like additional assertions, debug messages and so on.

Yes, you are right. Looking into, Debug also sets -O0 und -ggdb. Removed it.

mgorny · 2018-04-29T07:52:58Z

net-im/spectrum2/spectrum2-2.0.6.ebuild

+	fi
+
+	local mycmakeargs=(
+		-DENABLE_DOCS="$(usex doc ON OFF)" \


You don't need to force ON OFF for most of CMake projects. It handles the default yes/no just as well.

Even, when CMakeLists.txt uses itself ON/OFF?

Yes. As long as they use if (FOO) CMake automagically handles different values for on/off, yes/no, etc. You'd need explicit on/off only if they did direct string comparison like IF (FOO STREQUAL "ON")

Changed to YES and NO. But most eBuilds seems to use ON and OFF?

Okay, now I got it ;-)

ConiKost · 2018-04-29T14:50:10Z

I also pushed directly to 2.0.7, which was released 2 days ago.

ConiKost · 2018-04-29T17:25:24Z

* QA Notice: Files built without respecting LDFLAGS have been detected
*  Please include the following list of files in your report:
* /usr/bin/spectrum2

Will have a look.

ConiKost · 2018-04-29T18:28:29Z

LDFLAGS are now also fixed.

Dessa · 2018-05-01T22:31:10Z

net-im/spectrum2/spectrum2-2.0.7.ebuild

+
+inherit cmake-utils user
+
+DESCRIPTIYES="An open source instant messaging transport"


how did that happen? :)

WTF? I have no clue, how this did happen :x

Dessa · 2018-05-02T16:19:52Z

net-im/spectrum2/metadata.xml

+		<flag name="irc">Enable the IRC backend, based on <pkg>net-im/libcommuni</pkg>.</flag>
+		<flag name="purple">Enable the libpurple backend, based on <pkg>net-im/pidgin</pkg>.</flag>
+		<flag name="sms">Enable the SMS backend, based on <pkg>app-mobilephone/smstools</pkg>.</flag>
+		<flag name="twitter">Enable the Twitter backend, based on <pkg>net-im/swiften</pkg>.</flag>


this is not correct, twitter is "based" on net-misc/curl

Whoops. Thanks! Fixed.

Dessa · 2018-05-02T22:24:09Z

net-im/spectrum2/spectrum2-2.0.7.ebuild

+	einstalldocs
+
+	# Remove installed html docs, since they are also installed in /usr/share/docs
+	rm -fr "${D}"/var/lib/spectrum2_manager/html || die


why? this seems to be no documentation but something for the webui this package has (which i have never used so i can't really tell anything about it)

Hm, you are right. Changed. Thanks. I also never used it.

Closes: https://bugs.gentoo.org/291437 Package-Manager: Portage-2.3.24, Repoman-2.3.6 RepoMan-Options: --force

gentoo-repo-qa-bot · 2018-06-24T20:02:21Z

Pull request CI report

Report generated at: 2018-06-24 20:02 UTC
Newest commit scanned: fa07391
Status: ❌ broken

New issues caused by PR:
https://qa-reports.gentoo.org/output/gentoo-ci/e89020a/output.html#net-im/spectrum2

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/e89020a/output.html#dev-python/riak-python-client

tamiko and others added 23 commits April 25, 2018 16:43

sci-libs/adolc: update live ebuild

c71b51b

Package-Manager: Portage-2.3.31, Repoman-2.3.9

sci-libs/adolc: remove obsolete versions

cec5c11

Package-Manager: Portage-2.3.31, Repoman-2.3.9

sci-libs/adolc: always enable essential features

dd99606

Package-Manager: Portage-2.3.31, Repoman-2.3.9

sys-kernel/rt-sources: version bump to 3.18.104_p101

2854eb7

Package-Manager: Portage-2.3.31, Repoman-2.3.9 Closes: gentoo#8127

net-misc/youtube-viewer: Bump testing to 3.3.4 release, drop 3.2.8 st…

8613c36

…able in favour of 3.3.3 stable Package-Manager: Portage-2.3.31, Repoman-2.3.9 Closes: gentoo#8126

www-apache/mod_access_dnsbl: fix HOMEPAGE.

20c784c

Package-Manager: Portage[mgorny]-2.3.26.1 Closes: gentoo#8015

net-dns/getdns: add systemd unit files

f3cafd1

Signed-off-by: Anthony G. Basile <blueness@gentoo.org>

www-apps/drupal: Security bump to releases 7.59 and 8.5.3 to fix SA-C…

b0f2f99

…ORE-2018-004. Package-Manager: Portage-2.3.24, Repoman-2.3.6

app-admin/go-updater: Version bump to 0.2.0

20267cf

Package-Manager: Portage-2.3.31, Repoman-2.3.9

app-shells/thefuck: Version bump to 3.26

4fa1af7

Package-Manager: Portage-2.3.31, Repoman-2.3.9

app-admin/vault: Version bump to 0.10.1

8723d6f

Package-Manager: Portage-2.3.31, Repoman-2.3.9

app-admin/certmgr: Initial version

9e62781

Package-Manager: Portage-2.3.31, Repoman-2.3.9

www-apps/hugo: Version bump to 0.40.1

e54a011

Package-Manager: Portage-2.3.31, Repoman-2.3.9

app-emulation/lxc: fix QA issues

db82572

Package-Manager: Portage-2.3.31, Repoman-2.3.9

app-emulation/lxc: drop obsolete versions

0efdce0

Package-Manager: Portage-2.3.31, Repoman-2.3.9

dev-db/etcd: Remove old

cf1f973

Package-Manager: Portage-2.3.31, Repoman-2.3.9

net-fs/minio: Update snapshot

ee5b432

Package-Manager: Portage-2.3.31, Repoman-2.3.9

dev-python/python-novaclient: 9.1.2 bup

3b73272

Package-Manager: Portage-2.3.27, Repoman-2.3.9

net-analyzer/icinga2: 2.8.4 bup

d556fe9

Package-Manager: Portage-2.3.27, Repoman-2.3.9

www-apps/icingaweb2: 2.5.2 bup

b21bfd8

Package-Manager: Portage-2.3.27, Repoman-2.3.9

sys-cluster/nova: 16.1.2 and 17.0.3 bup

8cb4a9a

Package-Manager: Portage-2.3.27, Repoman-2.3.9

app-misc/faq: Initial version

e3d769f

Package-Manager: Portage-2.3.31, Repoman-2.3.9

johu added 4 commits April 26, 2018 20:44

media-fonts/liberation-fonts: Remove 1.07.4

0537ad1

Overshadowed by 2.00.x, no reverse deps. Package-Manager: Portage-2.3.31, Repoman-2.3.9

media-fonts/liberation-fonts: Fix SRC_URI

7134d03

Reported-by: putty_bug@online.de Closes: https://bugs.gentoo.org/651816 Package-Manager: Portage-2.3.31, Repoman-2.3.9

media-fonts/liberation-fonts: Revision bump 2.00.1-r3

de05aa9

EAPI 6. Package-Manager: Portage-2.3.31, Repoman-2.3.9

media-fonts/liberation-fonts: Remove 2.00.1-r2

404ee3a

Package-Manager: Portage-2.3.31, Repoman-2.3.9

ConiKost force-pushed the spectrum2 branch 2 times, most recently from becfbd0 to 72542ac Compare April 28, 2018 09:57

mgorny requested changes Apr 29, 2018

View reviewed changes

ConiKost force-pushed the spectrum2 branch 2 times, most recently from f92407e to b39c5b5 Compare April 29, 2018 14:48

ConiKost force-pushed the spectrum2 branch from b39c5b5 to 6e08e9d Compare April 29, 2018 17:12

ConiKost force-pushed the spectrum2 branch 2 times, most recently from ecdbbe3 to 84fed2d Compare April 29, 2018 18:27

ConiKost force-pushed the spectrum2 branch from 84fed2d to 4d00380 Compare April 29, 2018 19:30

Dessa reviewed May 1, 2018

View reviewed changes

ConiKost force-pushed the spectrum2 branch 3 times, most recently from 7540192 to 823296f Compare May 2, 2018 09:22

Dessa reviewed May 2, 2018

View reviewed changes

ConiKost force-pushed the spectrum2 branch from 823296f to 1fe1af2 Compare May 2, 2018 21:55

Dessa reviewed May 2, 2018

View reviewed changes

ConiKost force-pushed the spectrum2 branch from 1fe1af2 to ac51f0e Compare May 2, 2018 22:27

ConiKost force-pushed the spectrum2 branch from ac51f0e to bd56606 Compare May 11, 2018 14:31

ConiKost force-pushed the spectrum2 branch from bd56606 to 35780ba Compare June 24, 2018 19:13

net-im/spectrum2: New package

fa07391

Closes: https://bugs.gentoo.org/291437 Package-Manager: Portage-2.3.24, Repoman-2.3.6 RepoMan-Options: --force

ConiKost force-pushed the spectrum2 branch from 35780ba to fa07391 Compare June 24, 2018 19:15

ConiKost mentioned this pull request Jul 7, 2018

net-im/spectrum2: New package #9098

Closed


		inherit cmake-utils user

		DESCRIPTIYES="An open source instant messaging transport"

net-im/spectrum2: New package #7815

net-im/spectrum2: New package #7815

Conversation

ConiKost commented Apr 4, 2018

gentoo-repo-qa-bot commented Apr 4, 2018

Dessa commented Apr 4, 2018

ConiKost commented Apr 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ConiKost commented Apr 29, 2018

ConiKost commented Apr 29, 2018

ConiKost commented Apr 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dessa May 2, 2018 • edited Loading

Choose a reason for hiding this comment

ConiKost May 2, 2018 • edited Loading

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Jun 24, 2018

ConiKost commented Apr 5, 2018 •

edited

Loading

Dessa May 2, 2018 •

edited

Loading

ConiKost May 2, 2018 •

edited

Loading