-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net-im/spectrum2: New package #7815
Conversation
Pull Request assignment Areas affected: ebuilds net-im/spectrum2: @gentoo/proxy-maint (new package) Bugs linked: 291437 In order to force reassignment and/or bug reference scan, please append |
i have a question since im still using my own version from my overlay: does this still suffer of the massive overlinking due to swiften-config? |
Yes, I do also have this observed. Seems to be still the case. |
Package-Manager: Portage-2.3.31, Repoman-2.3.9
Package-Manager: Portage-2.3.31, Repoman-2.3.9
Package-Manager: Portage-2.3.31, Repoman-2.3.9
Package-Manager: Portage-2.3.31, Repoman-2.3.9 Closes: gentoo#8127
…able in favour of 3.3.3 stable Package-Manager: Portage-2.3.31, Repoman-2.3.9 Closes: gentoo#8126
Package-Manager: Portage[mgorny]-2.3.26.1 Closes: gentoo#8015
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
…ORE-2018-004. Package-Manager: Portage-2.3.24, Repoman-2.3.6
Package-Manager: Portage-2.3.31, Repoman-2.3.9
Package-Manager: Portage-2.3.31, Repoman-2.3.9
Package-Manager: Portage-2.3.31, Repoman-2.3.9
Package-Manager: Portage-2.3.31, Repoman-2.3.9
Package-Manager: Portage-2.3.31, Repoman-2.3.9
Many notable changes: 1. Drop python and lua. Bindings are no longer bundled with LXC and live in separate packages. 2. Drop cgmanager USE flag. cgmanager isn't supported anymore by upstream. 3. Remove versionator inherit. It wasn't used. 4. Remove two patches which were simple cherry pick from upstreams. They're applied upstream now. 5. Remove notice about path change in v1.1. It's been a while, it lost relevance. 6. Remove start-ephemeral bash completion. Upstream finally removed it from its own completions. 7. Add "pam" USE flag for the compilation and installation of the new builtin "pam_cgfs.so" module. Closes: https://bugs.gentoo.org/652582 Closes: gentoo#7934 Package-Manager: Portage-2.3.24, Repoman-2.3.6 Signed-off-by: Matthias Maier <tamiko@gentoo.org>
Package-Manager: Portage-2.3.31, Repoman-2.3.9
Package-Manager: Portage-2.3.31, Repoman-2.3.9
Package-Manager: Portage-2.3.31, Repoman-2.3.9
Package-Manager: Portage-2.3.31, Repoman-2.3.9
Package-Manager: Portage-2.3.27, Repoman-2.3.9
Package-Manager: Portage-2.3.27, Repoman-2.3.9
Package-Manager: Portage-2.3.27, Repoman-2.3.9
Package-Manager: Portage-2.3.27, Repoman-2.3.9
Package-Manager: Portage-2.3.31, Repoman-2.3.9
Overshadowed by 2.00.x, no reverse deps. Package-Manager: Portage-2.3.31, Repoman-2.3.9
Reported-by: putty_bug@online.de Closes: https://bugs.gentoo.org/651816 Package-Manager: Portage-2.3.31, Repoman-2.3.9
EAPI 6. Package-Manager: Portage-2.3.31, Repoman-2.3.9
Package-Manager: Portage-2.3.31, Repoman-2.3.9
becfbd0
to
72542ac
Compare
@@ -0,0 +1,40 @@ | |||
#!/sbin/openrc-run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please modernize this:
- Use
command
etc. to avoid redundant phases. - Use
checkpath
to create directories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not seeing the first change though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I misunderstood this. I see now, whats meant by command
.
I've updated the script, but there is one thing, I miss. I can't set the args based on start or stop.
So I had to keep the stop function. Is there a better way?
IUSE="debug doc frotz irc mysql postgres purple sms sqlite test twitter xmpp" | ||
REQUIRED_USE="|| ( mysql postgres sqlite )" | ||
|
||
DEPEND="dev-libs/boost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:=
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
|
||
DEPEND="dev-libs/boost | ||
dev-libs/expat | ||
dev-libs/libxml2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does it use two different XML libraries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure, I see both are used, if found by CMakeLists.txt. ldd
confirms linked against both.
But it also works, if linked against only one of them. I made a new use flag expat
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please investigate the code. It may indeed need only one of them but accidentally link to both. But it may also have independent features that use either (e.g. some old code using expat and new code using libxml2, or the other way around).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, hard to say. I don't see any references. I see, that in CMakeLists.txt always includes expat
and libxml2
, if available. But: Running lddtree
on the compiles binaries, I can clearly see, only expat is linked, libxml2 not, even when installed. On the other hand, the official debian package depends on libxml2-dev
.. any ideas?
dev-libs/expat | ||
dev-libs/libxml2 | ||
dev-libs/log4cxx | ||
dev-libs/jsoncpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:=
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
dev-libs/jsoncpp | ||
dev-libs/openssl:0= | ||
dev-libs/popt | ||
dev-libs/protobuf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:=
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
|
||
src_configure() { | ||
if use debug; then | ||
CMAKE_BUILD_TYPE="Debug" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the Readme, Debug
enables debugging symbols.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check if that means -g*
flags. If it does, please remove the flag since we do that via altering CFLAGS directly whenever necessary. USE=debug
is for things like additional assertions, debug messages and so on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right. Looking into, Debug
also sets -O0
und -ggdb
. Removed it.
fi | ||
|
||
local mycmakeargs=( | ||
-DENABLE_DOCS="$(usex doc ON OFF)" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to force ON OFF
for most of CMake projects. It handles the default yes/no just as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even, when CMakeLists.txt uses itself ON/OFF?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. As long as they use if (FOO)
CMake automagically handles different values for on/off, yes/no, etc. You'd need explicit on/off only if they did direct string comparison like IF (FOO STREQUAL "ON")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to YES
and NO
. But most eBuilds seems to use ON
and OFF
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, now I got it ;-)
f92407e
to
b39c5b5
Compare
I also pushed directly to 2.0.7, which was released 2 days ago. |
Will have a look. |
ecdbbe3
to
84fed2d
Compare
LDFLAGS are now also fixed. |
|
||
inherit cmake-utils user | ||
|
||
DESCRIPTIYES="An open source instant messaging transport" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how did that happen? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WTF? I have no clue, how this did happen :x
7540192
to
823296f
Compare
net-im/spectrum2/metadata.xml
Outdated
<flag name="irc">Enable the IRC backend, based on <pkg>net-im/libcommuni</pkg>.</flag> | ||
<flag name="purple">Enable the libpurple backend, based on <pkg>net-im/pidgin</pkg>.</flag> | ||
<flag name="sms">Enable the SMS backend, based on <pkg>app-mobilephone/smstools</pkg>.</flag> | ||
<flag name="twitter">Enable the Twitter backend, based on <pkg>net-im/swiften</pkg>.</flag> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not correct, twitter is "based" on net-misc/curl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops. Thanks! Fixed.
einstalldocs | ||
|
||
# Remove installed html docs, since they are also installed in /usr/share/docs | ||
rm -fr "${D}"/var/lib/spectrum2_manager/html || die |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? this seems to be no documentation but something for the webui this package has (which i have never used so i can't really tell anything about it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, you are right. Changed. Thanks. I also never used it.
Closes: https://bugs.gentoo.org/291437 Package-Manager: Portage-2.3.24, Repoman-2.3.6 RepoMan-Options: --force
Pull request CI report Report generated at: 2018-06-24 20:02 UTC New issues caused by PR: Issues already there before the PR (double-check them): |
net-im/spectrum2: New package
Closes: https://bugs.gentoo.org/291437