Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolchain-funcs.eclass: do not set --with-float for arm multilib #9960

Conversation

eugene-bright
Copy link
Contributor

Setting --with-multilib-list profiles is incompatible
with --with-arch/cpu/fpu/float/mode options.

We should avoid passing --with-float option at least for arm-* multilib.

Closes: https://bugs.gentoo.org/666896

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Areas affected: eclasses
Packages affected: (none)

@gentoo/github

Linked bugs

Bugs linked: 666896

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. bug linked Bug/Closes found in footer, and cross-linked with the PR. no signoff One or more commits do not indicate GCO sign-off. labels Sep 23, 2018
Setting `--with-multilib-list` profiles is incompatible
with `--with-float` option.

We should avoid passing `--with-float` option at least for arm-* multilib.

Closes: https://bugs.gentoo.org/666896
Signed-off-by: Eugene Bright <eugene@bright.gdn>
@eugene-bright
Copy link
Contributor Author

Signoff was added.

@Zlogene
Copy link
Contributor

Zlogene commented Sep 23, 2018

Please send it to the toolchain@gentoo.org and the gtntoo dev ml

@Zlogene Zlogene closed this Sep 23, 2018
@Zlogene
Copy link
Contributor

Zlogene commented Sep 23, 2018

I mean as a patch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug linked Bug/Closes found in footer, and cross-linked with the PR. need assignment It was impossible to assign the PR correctly. Please assign it manually. no signoff One or more commits do not indicate GCO sign-off.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants