Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"force" is defined incorrectly. #17

Closed
Chris-Cunningham opened this issue Jul 30, 2014 · 3 comments
Closed

"force" is defined incorrectly. #17

Chris-Cunningham opened this issue Jul 30, 2014 · 3 comments

Comments

@Chris-Cunningham
Copy link
Contributor

Since Force is kg m/s^2, and

mass: 8000
length: 1
time: 20

We should have force: 8000+1-40 = 7961

However, in "kinds", force is incorrectly described with the identifier 7981. So, a N_s will be described as a force if you use Qty('1 N_s').kind()

@Chris-Cunningham
Copy link
Contributor Author

I'm rather new to github, but I will try to fix and and make a pull request.

@rage-shadowman
Copy link
Contributor

FYI - I just looked into ruby-units and in "lib/ruby_units/unit.rb" (line 105) force is defined as 7961 (as @Chris-Cunningham has stated). In that same file, 7981 is labeled "momentum".

It might be worthwhile to resync the kinds between ruby-units and js-quantities again.

@gentooboontoo
Copy link
Owner

Closed (PR #18 merged). New issue #19 created to reconcile kind definitions with ruby-units.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants