Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix atom handling #115

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Fix atom handling #115

merged 1 commit into from
Oct 30, 2018

Conversation

tusbar
Copy link
Contributor

@tusbar tusbar commented Oct 30, 2018

Support text/xml and application/xml content types.
Go on to the next analyzer if the input is not an atom feed.
Return an empty array of children for empty feeds.

Support text/xml and application/xml content types.
Go on to the next analyzer if the input is not an atom feed.
Return an empty array of children for empty feeds.
@tusbar tusbar added the bug label Oct 30, 2018
@tusbar tusbar added this to the 3.1.1 milestone Oct 30, 2018
@tusbar tusbar self-assigned this Oct 30, 2018
@codecov
Copy link

codecov bot commented Oct 30, 2018

Codecov Report

Merging #115 into master will decrease coverage by 0.16%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   92.38%   92.21%   -0.17%     
==========================================
  Files          23       23              
  Lines         420      424       +4     
==========================================
+ Hits          388      391       +3     
- Misses         32       33       +1
Impacted Files Coverage Δ
lib/http/analyzers/atom.js 96.66% <93.33%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c84fb7...bcbda7b. Read the comment docs.

@tusbar tusbar merged commit c5a092b into master Oct 30, 2018
@tusbar tusbar deleted the tusbar/fix-atom branch October 30, 2018 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant