Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating openlayers to v6.4.3 #652

Closed
simonseyock opened this issue Oct 12, 2020 · 4 comments
Closed

Updating openlayers to v6.4.3 #652

simonseyock opened this issue Oct 12, 2020 · 4 comments

Comments

@simonseyock
Copy link
Member

ExtJS components in openlayers controls and overlays do not work out-of-the-box as the click events get swallowed by openlayers. This is fixed in openlayers v6.4.3.

Because of this I looked into updating the openlayers version and took some first steps in #651

It seems pretty straight forward and I hope I will at some point get the time to complete this.

@enorton
Copy link

enorton commented Dec 16, 2020

@simonseyock I've got your pull request checked out and so far 6.4.3 seems to work. I was wondering what else was on the to do list for this. I'm fairly new to geoext and openlayers so I'm not sure what to look for.

@simonseyock
Copy link
Member Author

@enorton As the releases v5.0.0 and v6.0.0 contain breaking changes I was going through the upgrade notes in
https://github.com/openlayers/openlayers/releases/tag/v5.0.0 and
https://github.com/openlayers/openlayers/releases/tag/v6.0.0
I was currently at the point 'Removal of optional this arguments.' of v5.0.0 which is probably the change which caused the most code updates.

@simonseyock
Copy link
Member Author

I wrote back then in the above linked issue in cpsi-mapview:

The only thing that I think is a little more work is the overview map - it can no longer show all parent layers but needs it's own layers.

@simonseyock
Copy link
Member Author

simonseyock commented Jun 4, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants