Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow searching/filtering across all years #17

Open
geoffrich opened this issue Jan 16, 2023 · 3 comments
Open

Allow searching/filtering across all years #17

geoffrich opened this issue Jan 16, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@geoffrich
Copy link
Owner

From #14

I couldn't find a way to search for a title over all the years, e.g. when I input "amazing", I want to get all the ASM issues from 1963 onward

@geoffrich
Copy link
Owner Author

This one will be tricky, some thoughts:

We currently load data for each year from the Marvel API and cache it in redis for 24 hours. So there's not an easy way to query data for all years. We either:

  • call Marvel API search endpoint with query (depending on usage, this could cut off API access since we have limited requests per day)
  • load data for a certain range of years (e.g. 1970-1975) and do the filtering ourselves

Though option 2 would be somewhat unsatisfying for those who want a truly global search (as originally requested).

We would probably want to keep filtering for option 2 strictly server-side due to the amount of data required.

I wonder if having dedicated series pages would mitigate some of the need for this issue.

@geoffrich
Copy link
Owner Author

Alternatively, we could do option 1, but build in a way to track API key usage and cut off the feature once we hit a certain threshold of calls

@geoffrich geoffrich added the enhancement New feature or request label Jan 16, 2023
This was referenced Jan 16, 2023
@gkaissis
Copy link

I reckon the easiest way to do this is to do one mega-API pull of all 55.000+ titles in the Marvel Database and cache them, then every day just check if any titles have been updated in the database and pull just them and update or add whatever changed. I actually did the mega pull earlier, its around 200 MB of JSON (and I didn’t get locked out despite doing around 6,000 calls in total). Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants