Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smarter patches #2

Closed
Geogi opened this issue May 11, 2020 · 3 comments
Closed

Smarter patches #2

Geogi opened this issue May 11, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@Geogi
Copy link
Owner

Geogi commented May 11, 2020 •
edited
Loading

Right now pushing a patch reverts the -dev prefix, which is bad (see wiki). This was made because of possible interactions with --for (i.e. pushing a v1.0.1 when v1.1 exists should not create a v1.1-dev) but even beyond that some thinking may be necessary.

Should patch releases go to a different branch ? We probably don't want to see the manifest in master do this :

  • v1.1 is released: v1.2.0-dev
  • v1.1.1 is released: rollback manifest with v1.1.1, then v1.2.0-dev
  • etc.
@Geogi Geogi added the enhancement New feature or request label May 11, 2020
@Geogi Geogi added this to the v3 milestone May 11, 2020
@Geogi
Copy link
Owner Author

Geogi commented May 11, 2020

Actually I think we do.

This will be fixed by changing the predicates that dictates whether to do the whole "post-version" thing from "is a patch version" to "the post-version does not already exist".

This should work for both the normal case and the --for case.

@Geogi Geogi removed this from the v3 milestone May 11, 2020
@Geogi Geogi added bug Something isn't working and removed enhancement New feature or request labels May 11, 2020
@Geogi
Copy link
Owner Author

Geogi commented May 11, 2020

Re-tagging as a bug. I got confused but the solution above is the expected behavior in my opinion. Will fix now.

Geogi pushed a commit that referenced this issue May 11, 2020
apply fixes for #2
0ddf7e9
@Geogi Geogi mentioned this issue May 11, 2020
Merged
@Geogi
Copy link
Owner Author

Geogi commented May 11, 2020

Confirmed fixed by #3

@Geogi Geogi closed this as completed May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Geogi