Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The map window is too narrow in height. #895

Open
SDymon opened this issue Nov 8, 2023 · 8 comments
Open

The map window is too narrow in height. #895

SDymon opened this issue Nov 8, 2023 · 8 comments
Labels
-easy- Difficulty to fix: easy Contributions welcomed Feel free to contribute to the project theme Design issues

Comments

@SDymon
Copy link

SDymon commented Nov 8, 2023

Скрин

@kumy
Copy link
Member

kumy commented Nov 14, 2023

@kumy kumy added good first issue Good for newcomers -easy- Difficulty to fix: easy labels Nov 14, 2023
@SDymon
Copy link
Author

SDymon commented Nov 15, 2023

Если кто-то хочет сделать пиар, это здесь https://github.com/geokrety/geokrety-website/blob/main/website/public/app-ui/css/app.scss#L51-L53 .

I don’t understand which parameter regulates the height of the map window. I think it needs to be doubled.

@kumy
Copy link
Member

kumy commented Nov 15, 2023

Then height: 800px on quoted line should do the trick.

@SDymon
Copy link
Author

SDymon commented Nov 15, 2023

In that case I think the issue will be resolved.

@kumy
Copy link
Member

kumy commented Nov 15, 2023

Just thought: as such it will also affect the map height on mobile. the CSS should be made to have a specific size on desktop and another on mobile (400px) is enough for mobile.

@SDymon
Copy link
Author

SDymon commented Nov 15, 2023

In this case, it should be saved in the user settings, as well as amount of geokret's displayed on the page. At the moment, this does not work when re-authorizing (this functionality simply does not exist)

@kumy
Copy link
Member

kumy commented Nov 15, 2023

In this case, it should be saved in the user settings

hum, storing the prefered map height in the user setting is a bit complicated, as the css are not managed by php. And that would not make the sizes different on desktop and mobile.

I suggest to define the value twice, one with the default value for desktop, and a second enclosed by @media (max-width: 991px) {} for mobile (we may have other sizes for tablets...

At the moment, this does not work when re-authorizing (this functionality simply does not exist)

Sorry what do you mean? I can't get your thought with this issue context.

@SDymon
Copy link
Author

SDymon commented Nov 15, 2023

  1. I absolutely agree with the proposal to store settings separately for the desktop and separately for mobile.
  2. Perhaps I did not mention earlier and did not suggest the following defect for correction. At the moment, when viewing "My Inventory", 10 pieces are displayed by default. It is not comfortable. It is advisable that the setting of the quantity of displayed geokret's be saved.

@kumy kumy added Contributions welcomed Feel free to contribute to the project and removed good first issue Good for newcomers labels Dec 26, 2023
@kumy kumy added the theme Design issues label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-easy- Difficulty to fix: easy Contributions welcomed Feel free to contribute to the project theme Design issues
Projects
None yet
Development

No branches or pull requests

2 participants