Fix fire vertex removed event #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A test would be good, do you think you can do this? |
Falke-Design
approved these changes
Nov 13, 2021
|
Sorry, I was busy and just read your message. Your test looks good to me 👍 |
codeofsumit
reviewed
Dec 18, 2021
BaharWeb
pushed a commit
to BaharWeb/leaflet-geoman
that referenced
this pull request
May 13, 2022
* Fix fire vertex removed event * Add test * Move findDeepMarkerIndex into Utils and add it to the removeVertrex evt * Fix this.L.PM Co-authored-by: Falke Design <design.falke@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In draw polyline mode, the
pm:vertexaddedevent is fired like expected.Clicking "Remove last vertex" doesn't fire a
pm:vertexremovedevent.This pull request makes sure to fire this event.