Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type Return Improvements #1215

Merged
merged 6 commits into from
Nov 1, 2022
Merged

Type Return Improvements #1215

merged 6 commits into from
Nov 1, 2022

Conversation

TurtIeSocks
Copy link
Contributor

@TurtIeSocks TurtIeSocks commented Aug 22, 2022 •
edited
Loading

  • Adds overrides for both getGeomanLayers and getGeomanDrawLayers, giving better IDE feedback when writing TypeScript.
  • Adds TS support for setting a custom radius when creating CircleMarkers

Screen Shot 2022-08-22 at 7 01 46 PM

@TurtIeSocks
small type improvements
dfa27c6
@TurtIeSocks
more specific
79bebe8
@TurtIeSocks
Fix templineStyle options
b034bbe 
Adds TS support for setting a custom radius when creating CircleMarkers
Falke-Design
Falke-Design approved these changes Aug 24, 2022
View reviewed changes
Copy link
Collaborator

@Falke-Design Falke-Design left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codeofsumit codeofsumit merged commit 5996b42 into geoman-io:develop Nov 1, 2022
@TurtIeSocks TurtIeSocks deleted the type-improvements branch November 2, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Falke-Design Falke-Design Falke-Design approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TurtIeSocks @Falke-Design @codeofsumit