New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Projection to closed curves #1015
Conversation
@Florent-Michel do you have updates on this? :D |
…eomstats into discrete_curves
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hi @ninamiolane, sorry for the delay, I just wrote the unit tests related to this PR. However, when I tried to update my branch with git rebase upstream/master as said in the "Contributing" page, it created a lot of commits, which made the PR a bit messy. |
Advise to merge instead of rebase when it's been a while, to avoid the situation of #1015
Advise to merge instead of rebase when it's been a while, to avoid the situation of #1015
Hi @Florent-Michel, I've created a new branch and cherry-picked your commits only so that we can review your PR properly in #1053. If you want to edit it, you can pull the branch with
and then open a new PR. |
Thanks @nguigs, I pulled the branch, edited it and opened a new PR. |
Addition of classes for closed curves with a projection method.