groups disappear when unselected in user admin

[pvgenuchten]

login as a useradmin
in user management modify yourself
try to unselect a group
notice that the group vanishes (does not appear on the left column)

before

after

[josegar74]

I can't reproduce this at least in 3.4.x branch:

Test done:

• Login with User Administrator user.
• Edit the user information for the logged user.
• Remove a group from a profile --> the group is displayed in the left panel.

[josegar74]

With an incognito window I can reproduce it in 3.4.x also, the first time I load the user info.

But seem related to the fact that the first load not all groups are displayed:

Just reloading the page in the browser, see the difference:

[pvgenuchten]

another observation, if you login as a user with role useradmin, it makes sense to only allow the groups that this user is useradmin in to be assigned to other users. This however can lead to a situation that a user is already on a group (where the useradmin user is not a member of). The group will then be displayed as selected, but when unselected will be removed, because it is not assignable. In below picture, this is the "sample" group.

Although a bit unexpected, this could work. But I guess it would be preferrable to display the "sample" group as grayed out (and disallow to change it). An exception could be made for the case that persons modify themselves, in that scenario they may want to remove themselves from a group (without notifying the useradmin)

[josegar74]

@pvgenuchten, I haven't check in my test with User Administrator which groups are assigned to the user, but what seem a issue is that first time the page shows a set of groups and reloading the page shows a different set of groups. This seems a bug.

About the case you indicate, I think should be displayed the groups not allowed in the right panel, but should be not selectable by the User Administrator to be removed. But I'm afraid this case is no handle properly.

[PascalLike]

The problem is that the current selection remains selected from the previous interaction. So the issue happens after some specific interaction: for example, add 3 groups, remove one group and try to add it again.

The fix explain the issue better than any test :)

[pvgenuchten]

thank you @PascalLike

[pvgenuchten]

#3169 does not fuly close this issue (see PR comment)