backport - Multiselect directive bug #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvgenuchten
added
the
backport 3.4.4
|
@PascalLike some changes required, this does not fully close #3055 Indeed the groups are filtered out for which this user does not have useradmin role in that group. however if you then save the new groups assignment, the user loses his membership of the groups that were filtered out. GN needs to verify first if a useradmin is allowed to remove group membership on a user before effectuating. |
|
Hi @pvgenuchten, I have the impression that this deserves a separate issue and fix: what you're describing relates to saving with filtered values whereas what Antonio fixed relates to a bug in which values are visible or not. Also the fix was merged as is in master, so IMO we should merge it in the same state in 3.4.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport for issue #3055