Don't add JSESSIONID in url and set HttpOnly flag. Fixes #3094 #3099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josegar74
force-pushed
the
fix/jsessionid-remove-from-url
branch
from
45e449b
to
8f8fc74
Compare
juanluisrp
reviewed
Sep 18, 2018
There was a problem hiding this comment.
Tested. GN doesn't append the session id to the URL. However, the cookie JSESSIONID is stored without httpOnly flag allowing scripts to access its value and could be retrieved by an attacker in case of XSS.
https://www.owasp.org/index.php/HttpOnly#Using_Java_to_Set_HttpOnly
josegar74
force-pushed
the
fix/jsessionid-remove-from-url
branch
from
8f8fc74
to
79550bb
Compare
josegar74
changed the title
josegar74
force-pushed
the
fix/jsessionid-remove-from-url
branch
from
79550bb
to
dfbe434
Compare
|
Added |
juanluisrp
approved these changes
Sep 20, 2018
fxprunayre
pushed a commit
to fxprunayre/core-geonetwork
that referenced
this pull request
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.