Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor / Associated resources / Online source #3804

Merged

Conversation

fxprunayre
Copy link
Member

More and more online resources can be described in a metadata record. In some use case we have more than 40 ... Then the panel is not really easy to use and need some ordering and filtering capability.

  • Add sort by option by protocol, URL or title with direction

image

  • Add filter box when more than 10 online resources
  • Display all fields on 4 lines for better readability (all blocks with same height and same info). Was depending on protocols, presence of name, description, ... and fields length
  • Expand block on hover to read all details

image

* Add sort by option by protocol, URL or title with direction
* Add filter box when more than 10 online resources
* Display all fields on 4 lines for better readability (all blocks with same height and same info). Was depending on protocols,
presence of name, description, ... and fields length
* Expand block on hover to read all details
@fxprunayre fxprunayre added this to the 3.8.0 milestone May 13, 2019
@fxprunayre
Copy link
Member Author

@MichelGabriel if you could have a look that would be great ? I'm not 100% convinced by the last point, maybe you'll have better ideas ?

@fxprunayre fxprunayre requested a review from josegar74 May 14, 2019 09:56
@josegar74
Copy link
Member

When there's no resources the sort header is displayed, should be better to hide it:

associated-resources-sort-header

I'm getting also an odd issue when removing an online resource when the list contains 2 resources (in other cases seem fine), the other resource is not listed anymore, but adding a new one the one not removed is displayed again.

  1. Add 2 online resources with protocol Web address (URL)

  2. Remove 1 of them --> The list is empty

  3. Add a new online resource --> The list displays the new one and the one that was not removed.

@MichelGabriel
Copy link
Contributor

Everything works as expected. But I tried the 'expand block' on hover, I like the idea, but as the height of an item increases you get a 'bouncing' effect when hovering.

Another thing, I don't know if it's related to this PR, is that when I try to copy/paste a long description, only a couple of words are saved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants