Splitting the large GN stylesheet into smaller ones and speed up loading #4044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichelGabriel
changed the title
Before After ok but the total is the same. The focus is mainly to reduce the size of gn_search_default to have faster rendering of the base styles, right ? |
|
Yes, that's correct |
fxprunayre
approved these changes
Sep 23, 2019
fxprunayre
reviewed
Oct 24, 2019
| @import "ellipsis.less"; | ||
| @import "timeline.less"; |
There was a problem hiding this comment.
This is removed but not added anywhere else so layout is broken in record history, harvester history
There was a problem hiding this comment.
Should we add it back in gn-picker.less ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the large GeoNetwork stylesheet in smaller stylesheets.
This is done in order to speed up the loading of the different files. A browser can load these smaller files simultaneously. The first styles needed to draw the opening page are accessible faster. The page doesn't have to wait until the one large stylesheet is loaded.
The new GN stylesheet is now (more or less) half the size of the old one.