OWS Service / give higher priority to layer name than metadata/id when looking up layer #4362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes several Layer objects can be pointed to the same metadata record, as such breaking right after a Metadata URL match would mean we might be looking at the wrong Layer object.
fxprunayre
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes in a GetCapabilities response several Layer objects can be pointed to the same metadata record, such breaking right after the first metadata UUID and/or identifier match would mean we might be at the wrong Layer object.
This can be tested with the following record:
https://sextant.ifremer.fr/geonetwork/srv/api/records/f8ed7346-94ae-4a86-b38e-3b07f7e5bf6a/formatters/xml
Without this PR, the second WMS layer of this record ("Chenaux de la baie de Saint Brieuc") cannot be added to the map because the layer lookup always finds the first layer ("Habitats benthiques...").
The behaviour should not be changed other than that.
@fxprunayre apparently you're the last one to have modified this logic, please let me know if you think that fix is acceptable! thanks