Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transfer ownership to handle when the metadata workflow is enabled the approved version of the metadata with a working copy #6144

Merged
merged 1 commit into from Feb 2, 2022

Conversation

josegar74
Copy link
Member

Similar to the changes done in #5811, but for transfer ownership.

When the workflow is enabled the transfer ownership works fine in these cases:

  • records are in draft
  • records approved without working copy

But it's not working fine If the metadata is approved and has a working copy. In this case it's processing all the records, but updating only the working copy version, not the approved version.

This PR updates the transfer ownership API to handle both versions of the metadata. For now, in the total number of records are counted the approved and draft versions. This is something to improve in the report, but will require some refactor of the current report.


Test case:

  1. On a published record, create and save a working copy.
  2. in the editor board, select the record
  3. Hit the Selected Button and choose Transfer Ownership
  4. Choose any user to transfer ownership to

Without the change the UI displayed the old ownership.

With the changes the ownership is updated for the approved and working copy.

…bled the approved version of the metadata with a working copy
@josegar74 josegar74 added this to the 4.0.6 milestone Feb 1, 2022
@juanluisrp juanluisrp modified the milestones: 4.0.6, 4.0.7 Feb 2, 2022
Copy link
Contributor

@juanluisrp juanluisrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the described user case. It works. LGTM.

@josegar74 josegar74 merged commit f4f9bfe into geonetwork:main Feb 2, 2022
josegar74 added a commit that referenced this pull request Feb 2, 2022
…s enabled the approved version of the metadata with a working copy (#6144)
josegar74 added a commit to GeoCat/core-geonetwork that referenced this pull request Mar 4, 2022
josegar74 added a commit that referenced this pull request Mar 10, 2022
josegar74 added a commit that referenced this pull request Mar 10, 2022
@juanluisrp juanluisrp mentioned this pull request Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants