Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin / Harvesting / Order options according to processing. #6221

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

fxprunayre
Copy link
Member

Rework harvesting configuration pages in order to have a clear idea of
the various harvester steps in order.

Instead of basic/advanced configuration section, define first:

  • Connection to the data source
  • Configuration of the response processing.

In the processing order elements as they are done server side. For
harvester like CSW where many optional steps can be applied, user
knows now when xpath filtering is done, if XSL transformation is applied
before batch edits, ...

Add some icons for main sections.

eg. for CSW - define URL, then all search options, then configure response processing and privileges

image

Rework harvesting configuration pages in order to have a clear idea of
the various harvester steps in order.

Instead of basic/advanced configuration section, define first:
* Connection to the data source
* Configuration of the response processing.

In the processing order elements as they are done server side. For
harvester like CSW where many optional steps can be applied, user
knows now when xpath filtering is done, if XSL transformation is applied
before batch edits, ...

Add some icons for main sections.
@MichelGabriel
Copy link
Contributor

@fxprunayre Looks good! Found 2 things that probably have been there already:

  1. sortBy label is not translated
  2. shouldn't the option Copy harvester config from clipboard be Copy harvester config to clipboard?

@fxprunayre
Copy link
Member Author

  • sortBy label is not translated

Added in https://github.com/geonetwork/core-geonetwork/pull/6225/files#diff-c5938a7d14e1737f829ec02106a51e978241bc1ad03318e69f5d4f3864616667R307

shouldn't the option Copy harvester config from clipboard be Copy harvester config to clipboard?

No, check titellus#92, you copy an existing harvester and you can paste the config as a new one (it makes easy to share harvester config between catalogues).

@fxprunayre
Copy link
Member Author

shouldn't the option Copy harvester config from clipboard be Copy harvester config to clipboard?

But better "Paste harvester config"

@MichelGabriel
Copy link
Contributor

Ok, now I understand, yes, 'paste' would better fit the option

@fxprunayre
Copy link
Member Author

fxprunayre commented Apr 5, 2022

sortBy label is not translated
Ok, now I understand, yes, 'paste' would better fit the option

Done in the transifex update PR #6225 (to avoid conflicts)

Copy link
Contributor

@MichelGabriel MichelGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@fxprunayre fxprunayre merged commit e41e286 into main Apr 5, 2022
@fxprunayre fxprunayre deleted the 407-harvesterlayoutfollowingserveractionorder branch April 5, 2022 10:34
fxprunayre added a commit that referenced this pull request Apr 6, 2022
* i18n / Transifex updates.

* Admin / Config / UI / Restore HTML link in translations.

* i18n / Add missing key.

* i18n / Fix paste harvester config #6221 (comment).
fxprunayre added a commit that referenced this pull request Nov 21, 2022
* Add XML file support
* Add support for multiple URL
* Clarify options order (follow up of
  #6221)
* Add all missing translations
* Use XSL conversion combo instead of free text
fxprunayre added a commit that referenced this pull request Jan 18, 2023
* Harvester / Simple URL / Improvements

* Add XML file support
* Add support for multiple URL
* Clarify options order (follow up of
  #6221)
* Add all missing translations
* Use XSL conversion combo instead of free text

* XSL / Conversion / Remove transformation relying on a plugin not available by default

* XSL / Conversion / Remove transformation relying on a plugin not available by default

* Harvester / SimpleURL / Add support for ODS v2 API

* Harvester / SimpleURL / Report error when path are wrong. Use Pointer for UUID retrieval (required for ODS API v2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants