Batch edit / Improvements #6239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inserting a snippet eg. mrd:distributor in a non existing section mdb:distributionInfo/mrd:MD_Distribution/mrd:distributor a self closing mrd:distributor was created in addition to the inserted ones. Add some more tests inserting in parent, in non existing element, in element at position.
Related to #6235 and titellus#9.
josegar74
reviewed
Apr 22, 2022
| @@ -318,13 +318,6 @@ | |||
| </xsl:copy> | |||
| </xsl:template> | |||
|
|
|||
|
|
|||
| <!-- The topic category directive may create empty topic. --> | |||
There was a problem hiding this comment.
Why is this template removed?
There was a problem hiding this comment.
Because it was probably added as a workaround to the fact that "Inserting a snippet in an element which does not exist could create an additional self closing tag". The directive for topics category is using the XPath insert API and is this case.
| @@ -248,14 +248,6 @@ | |||
| </xsl:copy> | |||
| </xsl:template> | |||
|
|
|||
| <!-- ================================================================= --> | |||
|
|
|||
| <xsl:template | |||
There was a problem hiding this comment.
Same question as the previous one.
| @@ -85,7 +86,7 @@ public void getUsers() throws Exception { | |||
| .session(this.mockHttpSession) | |||
| .accept(MediaType.parseMediaType("application/json"))) | |||
| .andExpect(status().isOk()) | |||
| .andExpect(jsonPath("$", hasSize(5))) | |||
| .andExpect(jsonPath("$", hasSize(6))) | |||
There was a problem hiding this comment.
Not sure if this change is related to the PR?
There was a problem hiding this comment.
No, but the test was failing (because of https://github.com/geonetwork/core-geonetwork/blob/main/web/src/main/webapp/WEB-INF/classes/setup/sql/data/data-db-default.sql#L729)
josegar74
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add examples selector
To facilitate usage of the XPath batch editing and examples that can be easily picked up
In batch editor
In CSW harvester config
Thanks @vbombaerts for the ISO19115-3 examples.
Add copy/paste xpath config
Editing fix
Inserting a snippet in an element which does not exist could create an additional self closing tag
on a record with no distribution section will return
A workaround was define in update-fixed-info for topicCategory when using the standard editor.
Other changes