Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmis performance enhancements #6893

Merged
merged 5 commits into from Mar 13, 2023
Merged

Conversation

ianwallen
Copy link
Contributor

Cmis performance enhancements

  • As CMIS calls are slow - reduce cmis calls when inserting and updating properties during adding and updating resources.
  • Increase MaxItemsPerPage to 1000 to increase performance when there are over 100 attachments.
  • Fix bug with setting IncludeRelationships to none
  • Calculate default validation Status once and move to configuration.
  • Fixed bug where primary properties were not being copied during resource copy.
  • Other minor fixes.

- As CMIS calls are slow - reduce cmis calls when inserting and updating properties during adding and updating resources.
- Increase MaxItemsPerPage to 1000 to increase performance when there are over 100 attachments.
- Fix bug with setting IncludeRelationships to none
- Calculate default validation Status once and move to configuration.
- Fixed bug where primary properties were not being copied during resource copy.
- Other minor fixes.
@ianwallen ianwallen added this to the 4.2.4 milestone Mar 8, 2023
Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the code, but changes look good, please check the suggestions.

ianwallen and others added 4 commits March 10, 2023 16:40
…java

Co-authored-by: Jose García <josegar74@gmail.com>
…Store.java

Co-authored-by: Jose García <josegar74@gmail.com>
…Store.java

Co-authored-by: Jose García <josegar74@gmail.com>
Also updated some formatting.
@ianwallen ianwallen merged commit 306f5da into geonetwork:main Mar 13, 2023
6 checks passed
ianwallen added a commit that referenced this pull request Mar 14, 2023
* Cmis performance enhancements
- As CMIS calls are slow - reduce cmis calls when inserting and updating properties during adding and updating resources.
- Increase MaxItemsPerPage to 1000 to increase performance when there are over 100 attachments.
- Fix bug with setting IncludeRelationships to none
- Calculate default validation Status once and move to configuration.
- Fixed bug where primary properties were not being copied during resource copy.
- Other minor fixes.

* Update core/src/main/java/org/fao/geonet/resources/CMISConfiguration.java

Co-authored-by: Jose García <josegar74@gmail.com>

* Update core/src/main/java/org/fao/geonet/api/records/attachments/CMISStore.java

Co-authored-by: Jose García <josegar74@gmail.com>

* Update core/src/main/java/org/fao/geonet/api/records/attachments/CMISStore.java

Co-authored-by: Jose García <josegar74@gmail.com>

* Applied some constants based on code review
Also updated some formatting.

---------

Co-authored-by: Jose García <josegar74@gmail.com>
@ianwallen ianwallen deleted the cmis_improvements branch November 30, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants