Metadata editor / link to remote dataset improvements #7324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve the title extraction For HTML links, to support title elements with attributes. - Allow to define a custom title for the remote dataset link
fxprunayre
reviewed
Sep 11, 2023
...ui/src/main/resources/catalog/components/edit/onlinesrc/partials/remote-record-selector.html
Outdated
Show resolved
Hide resolved
fxprunayre
reviewed
Sep 11, 2023
...ui/src/main/resources/catalog/components/edit/onlinesrc/partials/remote-record-selector.html
Outdated
Show resolved
Hide resolved
fxprunayre
reviewed
Sep 11, 2023
...ui/src/main/resources/catalog/components/edit/onlinesrc/partials/remote-record-selector.html
Outdated
Show resolved
Hide resolved
…rtials/remote-record-selector.html Co-authored-by: François Prunayre <fx.prunayre@gmail.com>
…rtials/remote-record-selector.html Co-authored-by: François Prunayre <fx.prunayre@gmail.com>
…rtials/remote-record-selector.html Co-authored-by: François Prunayre <fx.prunayre@gmail.com>
fxprunayre
approved these changes
Sep 21, 2023
fxprunayre
added a commit
that referenced
this pull request
Oct 17, 2023
Some catalogues link records to others which can be in the same catalogue or in remote sites. Links are encoded using ```xml <gmd:source uuidref="https://ec.europa.eu/eurostat/cache/metadata/en/env_nwat_esms.htm" xlink:title="Water statistics on national level (env_nwat)" xlink:href="https://ec.europa.eu/eurostat/cache/metadata/en/env_nwat_esms.htm"/> ``` and the `xlink:title` may contain the remote record title (or the customized title cf. #7324) This adds the related records title to the full text search. Sample record https://sdi.eea.europa.eu/catalogue/srv/eng/catalog.search#/metadata/04b55edf-9a98-4123-87ab-7845af61d07d With that change searching for `env_nwat` will return the record due to the source dataset.
10 tasks
fxprunayre
added a commit
to eea/geonetwork-eea
that referenced
this pull request
Oct 17, 2023
Some catalogues link records to others which can be in the same catalogue or in remote sites. Links are encoded using ```xml <gmd:source uuidref="https://ec.europa.eu/eurostat/cache/metadata/en/env_nwat_esms.htm" xlink:title="Water statistics on national level (env_nwat)" xlink:href="https://ec.europa.eu/eurostat/cache/metadata/en/env_nwat_esms.htm"/> ``` and the `xlink:title` may contain the remote record title (or the customized title cf. geonetwork/core-geonetwork#7324) This adds the related records title to the full text search. Sample record https://sdi.eea.europa.eu/catalogue/srv/eng/catalog.search#/metadata/04b55edf-9a98-4123-87ab-7845af61d07d With that change searching for `env_nwat` will return the record due to the source dataset.
josegar74
pushed a commit
that referenced
this pull request
Oct 25, 2023
Some catalogues link records to others which can be in the same catalogue or in remote sites. Links are encoded using ```xml <gmd:source uuidref="https://ec.europa.eu/eurostat/cache/metadata/en/env_nwat_esms.htm" xlink:title="Water statistics on national level (env_nwat)" xlink:href="https://ec.europa.eu/eurostat/cache/metadata/en/env_nwat_esms.htm"/> ``` and the `xlink:title` may contain the remote record title (or the customized title cf. #7324) This adds the related records title to the full text search. Sample record https://sdi.eea.europa.eu/catalogue/srv/eng/catalog.search#/metadata/04b55edf-9a98-4123-87ab-7845af61d07d With that change searching for `env_nwat` will return the record due to the source dataset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if linking to a web page without title information, the title for the link was assigned to the full html.
With this change, the user can define a custom title for the remote dataset in this case:
or override the title extracted with a custom one: