Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter / Remove unused Groovy mode. #7346

Merged
merged 2 commits into from Sep 29, 2023
Merged

Conversation

fxprunayre
Copy link
Member

@fxprunayre fxprunayre commented Sep 19, 2023

Groovy formatter is unused and unmaintained in GeoNetwork. It is also unused in the (only one?) project which used it (geocat.ch) since ~2 years now.

This PR propose to remove it.

List of groovy formatters:

  • full_view (iso19139, iso19110, dublin-core),
  • partial_view (only iso19139)
  • xml_view
  • hierarchy_view

See
https://github.com/geonetwork/core-geonetwork/tree/main/schemas/iso19139/src/main/plugin/iso19139/formatter
https://github.com/geonetwork/core-geonetwork/tree/main/web/src/main/webapp/WEB-INF/data/data/formatter

@fxprunayre fxprunayre added this to the 4.4.0 milestone Sep 19, 2023
Groovy formatter is unused and unmaintained in GeoNetwork.
It is also unused in the (only one?) project which used it (geocat.ch)
since 2 years now.

This PR propose to remove it.
@fxprunayre fxprunayre added schema plugin change Indicate that this work introduces a schema plugin change. changelog labels Sep 21, 2023
@josegar74
Copy link
Member

@fxprunayre probably this file requires to be updated also:

case "groovy":
response.setContentType("text/x-groovy-source,groovy");
return;

Should not be removed the full test related to https://github.com/geonetwork/core-geonetwork/pull/7346/files#diff-2b14577e24e139d9bb75bd503ec5dbb1f4f78f926107b2fc022d9e228317a5a0R63 ?

@fxprunayre
Copy link
Member Author

@fxprunayre probably this file requires to be updated also:

case "groovy":
response.setContentType("text/x-groovy-source,groovy");
return;

Should not be removed the full test related to https://github.com/geonetwork/core-geonetwork/pull/7346/files#diff-2b14577e24e139d9bb75bd503ec5dbb1f4f78f926107b2fc022d9e228317a5a0R63 ?

Done. About the test, we can keep but indeed I think XSLT formatter never added extra resources like images/css/js in the formatter bundle. We can maybe cleanup this later if really unused.

@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@fxprunayre fxprunayre merged commit 04a4c6f into main Sep 29, 2023
9 of 10 checks passed
@fxprunayre fxprunayre deleted the 4-formattergroovyremoval branch September 29, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog schema plugin change Indicate that this work introduces a schema plugin change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants