Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor / Remove wrong ERROR log message on multilingual records #8049

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

fxprunayre
Copy link
Member

This type of errors were reported but are wrong on multilingual records:

2024-05-16T10:45:08,952 ERROR [geonetwork.editor] - Element not found at ref = 554
2024-05-16T10:45:08,953 ERROR [geonetwork.editor] - Element not found at ref = 556

Multilingual elements have reference like _lang_EN_123 and are managed by updatedLocalizedTextElement method and the schema plugin. There is no need to search for them in the preprocess phase.

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Funded by Ifremer

This type of errors were reported but are wrong on multilingual records:

```
2024-05-16T10:45:08,952 ERROR [geonetwork.editor] - Element not found at ref = 554
2024-05-16T10:45:08,953 ERROR [geonetwork.editor] - Element not found at ref = 556
```

Multilingual elements have reference like `_lang_EN_123` and are managed by `updatedLocalizedTextElement` method and the schema plugin. There is no need to search for them in the preprocess phase.
@fxprunayre fxprunayre added this to the 4.4.5 milestone May 16, 2024
@fxprunayre fxprunayre requested a review from josegar74 May 16, 2024 10:13
Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems working fine. Just added a comment to document a code condition.

Copy link

sonarcloud bot commented Jun 6, 2024

@fxprunayre fxprunayre merged commit 0758a8e into main Jun 6, 2024
9 checks passed
@fxprunayre fxprunayre deleted the 44-cleanuploggingformultilingualrecords branch June 6, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants