Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 4.2.x]XSL / Utility / Add multilingual support to getIndexField #8065

Merged
merged 1 commit into from
May 31, 2024

Conversation

ianwallen
Copy link
Contributor

Backport #8042

The function is not much used but can be tested by configuring a
multilingual metadata as CSW service.

Then the document title is the title of the metadata record and should
match UI language or use default if not found.
@ianwallen
Copy link
Contributor Author

@josegar74,
There were conflicts with
index/src/main/java/org/fao/geonet/index/es/EsRestClient.java

I resolved them but I'm not sure if there are any elastic search differenced that I should be aware of between 4.4 and 4.2. Could you review this.

Note: This back port is required for when #8044 is backported.

@ianwallen ianwallen requested a review from josegar74 May 17, 2024 12:20
@josegar74
Copy link
Member

@ianwallen I'll check if any change is required, thanks.

Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ianwallen I've tested as described by @fxprunayre in #8042 and looks ok the backport.

The metadata page displays the title element correctly:

  • In English UI: <title>CSW service metadata title (English)</title>
  • In French UI: <title>CSW service metadata title (French)</title>

@ianwallen ianwallen merged commit ec1b58b into 4.2.x May 31, 2024
6 of 9 checks passed
@ianwallen ianwallen deleted the backport-8042-to-4.2.x branch June 3, 2024 11:40
@ianwallen ianwallen added this to the 4.2.10 milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants