-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ammended error message and added strict option. #957
Conversation
…sing parameter.
@fxprunayre @Delawen How does this look to you guys now? I think Jeroen has tried to respond to all of your comments. Can we merge this? |
Should we merge this after the release? |
This is related to #956 |
Sounds good even if I'm not sure about adding empty elements to make XML valid in some cases for passing tests is really required #956 (comment). But as said to Jeroen yesterday, not sure those outputs formats are used a lot in the real - in most cases DC or ISO full is used. @grootstebozewolf you can add commits in an existing PR and push again, the PR will be updated. No need to create a new one each time. Could go in 3.0.0 probably if needed I think. |
Previous PR had many things that should have been kept private, I think that's why he created a new one. Going to check changes now... |
Looks much better now. I don't see why we can't add it to 3.0.0. But @fxprunayre is the one who is leading the version, he should be the one with the last word in my opinion. |
Ammended error message and added strict option.
Added strict option to check for typeNames, this is option is mandatory and checked for a correct error handleing in the GDI-DE testsuite validation.