Migrate nx + upgrades #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Created a new NX project from scratch using this doc: https://nx.dev/latest/angular/getting-started/nx-setup Recreated the previous project structure (apps and libs), and grouping libs by type as best as I could. Also copied the dependencies and NPM tasks from the previous package.json Commands run: npx create-nx-workspace --preset=angular nx generate @nrwl/angular:library ui/search nx generate @nrwl/angular:library ui/inputs nx generate @nrwl/angular:library ui/layout nx generate @nrwl/angular:library ui/widgets nx generate @nrwl/angular:library ui/catalog nx generate @nrwl/angular:library feature/editor nx generate @nrwl/angular:library feature/catalog nx generate @nrwl/angular:library feature/search nx generate @nrwl/angular:library feature/auth nx generate @nrwl/angular:library data-access/gn4 nx generate @nrwl/angular:library data-access/datafeeder nx generate @nrwl/angular:library util/i18n nx generate @nrwl/angular:library util/shared nx generate @nrwl/angular:app datafeeder ng add @angular/elements ng add @angular/platform-server 2. Copied both datafeeder and search projects from the previous structure 3. copied all libs which were reorganized in order to have smaller libs and a more granular dependency graph 4. regenerated the API clients (datafeeder and gn4) agains the specs in the repo; this required adapting the generate-api tool a bit 5. adapted tsconfig to avoid errors linked to strict checking
Reworked the fuzzy-search and ui-autocomplete components to rely on the material autocomplete component Created a new helper in the ElasticSearch service to build an autocomplete query payload
ESLint is stricter on many things so many adaptations were made, notably: * empty functions and lifecycle methods removed * using `object` type * fixed relative/absolute import paths to respect module boundaries Also all components were adapted to use the `gn-ui` prefix, disregarding which lib or app they are from (this is the NX default). Note that there is still a circular dependency remaining
The test was relying on an element lookup based on CSS but the component prefix was not updated
change from angular 12 migration
jahow
force-pushed
the
migrate-nx
branch
4 times, most recently
from
743f50f
to
b0d8aab
Compare
also fix workflow formatting
jahow
force-pushed
the
migrate-nx
branch
4 times, most recently
from
711174e
to
d9802fa
Compare
fgravin
force-pushed
the
migrate-nx
branch
3 times, most recently
from
49b9010
to
cdba75c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core refactoring of the architecture