Returns ExtendedGeorchestraUser object when createUserInLdap set to true
#114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmauduit
force-pushed
the
extended-geor-users-when-create-account-in-ldap-true
branch
from
0bebc62
to
3e41367
Compare
pmauduit
force-pushed
the
extended-geor-users-when-create-account-in-ldap-true
branch
from
3e41367
to
c0f1a68
Compare
Considering the following configuration scenario: * external authentication (oidc/oauth2 or pre-auth) being configured * `createUsersInGeorchestraLdap` set to true Then the resolved GeorchestraUser should be an `ExtendedGeorchestraUser`, in order to have a behaviour coherent with the extended geOrchestra LDAP authentication. Without doing so, users externally authenticated will resolve as a classic GeorchestraUser, leading to missing http headers and breaking some geOrchestra applications (e.g. datafeeder, which requires the `sec-orgname` provided only when resolving to an `ExtendedGeorchestraUser`). This also refactors the LdapConfigProperties to GeorchestraGatewaySecurityConfigProperties, as the object is not only about LDAP, but also nests some other configureable features (OIDC, ...). Documentation has been updated to describe / explain the behaviour. Tests: * testsuite adapted * added specific tests case scenario
pmauduit
force-pushed
the
extended-geor-users-when-create-account-in-ldap-true
branch
from
a4f5563
to
204f91a
Compare
|
Thanks @groldan for the review
👍 |
|
thymeleaf templates for e.g. login are not resolved anymore after this merge, I cannot explain why for now, but hitting /login will return the "login" string as response body. |
pmauduit
added a commit
that referenced
this pull request
May 7, 2024
See #114 (comment) Using RestController will disable thymeleaf template integration, reverting back to Controller annotation instead. Tests: runtime in the docker composition provided at the root of the reppository.
pmauduit
added a commit
that referenced
this pull request
May 7, 2024
…er-merge-114 login - fix thymeleaf integration (reverts a modification from #114)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering the following configuration scenario:
createUsersInGeorchestraLdapset to trueThen the resolved
GeorchestraUsershould be anExtendedGeorchestraUser, in order to have a behaviour coherent with the geOrchestra LDAP authentication (via the classic login form provided by the gateway).Without doing so, users externally authenticated will resolve as a classic GeorchestraUser, leading to missing http headers and breaking some geOrchestra applications (e.g. datafeeder, which requires the
sec-orgnameprovided only when resolving to anExtendedGeorchestraUser).This also refactors the
LdapConfigPropertiestoGeorchestraGatewaySecurityConfigProperties, as the object is not only about LDAP, but also nests some other configureable features (OIDC, ...).Documentation has been updated to describe / explain the behaviour.
Tests:
IMPORTrole, being externally authenticated, I was able to import a dataset following the datafeeder wizard.