Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe adding is semi-successful and poorly handled if the image is too large to upload to Grocy #18

Open
georgegebbett opened this issue May 14, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@georgegebbett
Copy link
Owner

If you try to add a recipe with an image that is too large for Grocy to support (such as https://gabriellaquille.com/salmon-avocado-crispy-rice-paper-rolls/) then the recipe is added to Grocy, but without an image. An error is displayed in Recipe Buddy which implies that the whole thing has failed.

@georgegebbett georgegebbett added the bug Something isn't working label May 14, 2022
@the-despised
Copy link

the-despised commented Feb 5, 2023

This is not actually an issue with recipe buddy.
I had to update my PHP settings in grocy.env AND my reverse proxy to handle larger file sizes.

Recipe buddy is really not able to control much in this case. Error internally is a 413 Response too Large on the grocy side, due to server config. The API from grocy returns 500 Error which doesn't tell us a terribly lot about the problem.

Error handling could be improved dramatically, and for that reason alone I would keep the bug open, but change it to an improvement..

On to the config that fixed it...

nginx

server {
    listen 80;
    server_name grocy.local;
    client_max_body_size 50M;
}

grocy.env:

# PHP Environment variables
MAX_UPLOAD=50M
PHP_MAX_FILE_UPLOAD=50M
PHP_MAX_POST=100M
PHP_MEMORY_LIMIT=1024M

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants