-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SELECT expr;
which does not require FROM table
#1087
Conversation
Discussed offline. We will send a dummy batch instead of checking |
@gaurav274 @jiashenC Please review. We should be ready for a forecasting notebook after this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the PR looks good to me.
Just curious about the workflow of the forecasting model for my own knowledge.
- During training (i.e.,
CREATE FUNCTION
), the forecasting model reads a table and memorizes all of the data from the table to its internal state (e.g., weights). - During inference, the forecasting model outputs the prediction from its internal state.
Is this the reason why the SeqScan
is no longer needed during inference?
Yes. It always works on the original dataset or table. |
I see. Then, if the user wants the same model to work with a different dataset, the user needs to call |
That is correct. On the other hand, If I understand correctly, for forecasting, the same model can not work for other datesets. It is trained for a specific dataset. @americast who should have more knowledge in this space. |
Address the
SELECT Forecast(12) FROM AirData;
toSELECT Forecast(12);
in #1081SELECT expr;
.SELECT expr;
.