feat: sqlalchemy tests #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiashenC
approved these changes
Mar 27, 2023
| service = service_subclass() | ||
| table_tuples = service.get_all_entries() | ||
| self.assertTrue( | ||
| len(table_tuples) < 100 |
There was a problem hiding this comment.
Just curious, is it generally bad to have a large catalog table?
There was a problem hiding this comment.
Not really, I just added an assert for checking the contents of the table for now.
gaurav274
reviewed
Mar 27, 2023
eva/udfs/udf_bootstrap_queries.py
Outdated
| Open_udf_query, | ||
| Similarity_udf_query | ||
| # Disabled because required packages (eg., easy_ocr might not be preinstalled) | ||
| # YoloV5_udf_query, |
There was a problem hiding this comment.
We shouldn't disable this for release mode as else early users will have to manually run the create udf query. We can condition on mode here.
There was a problem hiding this comment.
Done. We now have three modes: debug/release: all UDFS, minimal: No YOLO
gaurav274
reviewed
Mar 28, 2023
| @@ -25,5 +25,8 @@ def setup_pytorch_tests(): | |||
| CatalogManager().reset() | |||
| execute_query_fetch_all("LOAD VIDEO 'data/ua_detrac/ua_detrac.mp4' INTO MyVideo;") | |||
| execute_query_fetch_all("LOAD VIDEO 'data/mnist/mnist.mp4' INTO MNIST;") | |||
| load_inbuilt_udfs() | |||
| load_udfs_for_testing() | |||
| from eva.udfs.udf_bootstrap_queries import YoloV5_udf_query | |||
There was a problem hiding this comment.
Any reason for having this separately?
There was a problem hiding this comment.
In case we want a more complex logic for picking UDFs later during testing
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YOLOis particular test cases (to avoid slowing down all test cases)