Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinates for some countries are incorrect #5

Closed
dex73 opened this issue Jul 1, 2019 · 6 comments
Closed

Coordinates for some countries are incorrect #5

dex73 opened this issue Jul 1, 2019 · 6 comments

Comments

@dex73
Copy link

dex73 commented Jul 1, 2019

Some countries, like Portugal, Ukraine, Lithuania have correct coordinates, that are inside bounds longitude +/-180, latitude +/-90.

On another side countries like Germany, France, Italy, Georgia etc have coordinates starting from 700... For example this is header of Italy

$ cat ./italy.json | head -n 30
{
  "type": "FeatureCollection",
  "features": [
    {
      "type": "Feature",
      "properties": {},
      "geometry": {
        "type": "Polygon",
        "coordinates": [
          [
            [
              727.5311279296875,
              43.77902662160831
            ],
            [
              727.5627136230469,
              43.77456454892858
            ],
            [
              727.5702667236327,
              43.78497553389676
            ],
            [
              727.5984191894531,
              43.781009658142914
            ],
            [
              727.6581573486328,
              43.77109381775651
            ],

ER: all coordinates are in longitude +/-180, latitude +/-90 bounds

@nomadkj
Copy link

nomadkj commented Jul 29, 2019

I ran into the same problem.
Is there a fix?

Thanks!

@georgique
Copy link
Owner

Please see #2 (comment)
Question is - do you see it as an issue, or is it causing real problems in some software?

@nomadkj
Copy link

nomadkj commented Jul 30, 2019

@georgique
As far as I'm aware of, the geojsons with coordinates greater than 180 cannot be used in Leaflet.
It won't show anything, so in that case it's not usable.

It's the best geojson library I could find, so I would really appreciate it if you could look into this!

@georgique
Copy link
Owner

I can look into it, but please try it with Leaflet and provide confirmation that it doesn't work. Otherwise it'd be waste of time.

@goodwin64
Copy link

Created a PR for this: #6

@dex73 @georgique please take a look when possible.

@georgique
Copy link
Owner

PR merged, issue is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants