Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change behaviour of the EvaObservations task on login vs compute node #263

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

danholdaway
Copy link
Contributor

Description

As requested by @Dooruk, EvaObservations can be run on a login node without using a large number of threads and annoying everyone on said node. Offers some protection when the task is accidentally run on a login node; unlike MPI, there is nothing to stop people overloading a login node when using threading in Python.

Dependencies

N/A

Impact

N/A

@danholdaway danholdaway marked this pull request as ready for review October 12, 2023 00:53
@danholdaway
Copy link
Contributor Author

Copy link
Collaborator

@Dooruk Dooruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both CLI and compute nodes work.

I'm certified happy!

@danholdaway danholdaway merged commit b65a6b4 into develop Oct 12, 2023
3 checks passed
@danholdaway danholdaway deleted the feature/eva_login_slurm branch October 12, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants