Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG/ISSUE] Benchmark plotting functions fail if cmpres passed as cubed sphere #27

Closed
lizziel opened this issue Sep 6, 2019 · 1 comment
Assignees
Labels
category: Bug Something isn't working topic: Cubed-Sphere Grid Pertains to cubed-sphere grids and/or regridding

Comments

@lizziel
Copy link
Contributor

lizziel commented Sep 6, 2019

The comparison resolution argument cmpres that is passed to benchmark.py function compare_single_level is supposed to be able to be either cubed sphere or lat-lon. However, if it is cubed sphere then the function fails due to a type error. This is because cmpres is passed as string but the function expects it to be integer if cubed sphere in certain places. All cubed sphere comparisons to date have not passed cmpres explicitly, and hence this bug has not been previously detected. The quick fix is to cast cmpres to integer if cubed sphere and passed explicitly.

A related issue occurrs in benchmark.py function compare_zonal_mean. If cmpres is passed as cubed sphere then the function fails with a type error. For zonal mean the comparison resolution should never be cubed sphere but this is not enforced. The quick fix is to override the passed cubed sphere resolution with lat-lon '1x1.25'.

@lizziel
Copy link
Contributor Author

lizziel commented Sep 6, 2019

This issue is fixed with e6cfee9.

@lizziel lizziel closed this as completed Sep 6, 2019
@yantosca yantosca added category: Bug Something isn't working topic: Cubed-Sphere Grid Pertains to cubed-sphere grids and/or regridding resolved labels Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Something isn't working topic: Cubed-Sphere Grid Pertains to cubed-sphere grids and/or regridding
Projects
None yet
Development

No branches or pull requests

2 participants