Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of em_examples for DC apps #52

Merged
merged 5 commits into from
Jun 28, 2017
Merged

Use of em_examples for DC apps #52

merged 5 commits into from
Jun 28, 2017

Conversation

thast
Copy link
Member

@thast thast commented Jun 22, 2017

  • add em_examples to requirements
  • removed outdated DC code from the repository
  • update notebook to reflect changes

@thast thast requested review from dccowan and lheagy June 22, 2017 19:54
@thast thast requested a review from yangdikun June 28, 2017 18:19
Copy link
Member

@dccowan dccowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things work well. Any final changes can be made while reviewing lab materials.

@dccowan dccowan merged commit 5613c76 into master Jun 28, 2017
@dccowan dccowan deleted the Thibaut_DC branch June 28, 2017 19:40
Copy link
Member

@lheagy lheagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importing * is a dangerous thing to do internally. I would recommend changing this

@@ -1,2 +1,3 @@
from . import DCLayers
from . import DCWidget
from em_examples.DCLayers import *
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend not importing * internally. This makes debugging a giant headache and also tends to clobber the namespace

from em_examples.DCLayers import class1, class2

@@ -8,3 +8,4 @@ Pillow
SimPEG
discretize
JSAnimation
em_examples
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants