-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of em_examples for DC apps #52
Conversation
thast
commented
Jun 22, 2017
- add em_examples to requirements
- removed outdated DC code from the repository
- update notebook to reflect changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things work well. Any final changes can be made while reviewing lab materials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Importing * is a dangerous thing to do internally. I would recommend changing this
@@ -1,2 +1,3 @@ | |||
from . import DCLayers | |||
from . import DCWidget | |||
from em_examples.DCLayers import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend not importing * internally. This makes debugging a giant headache and also tends to clobber the namespace
from em_examples.DCLayers import class1, class2
@@ -8,3 +8,4 @@ Pillow | |||
SimPEG | |||
discretize | |||
JSAnimation | |||
em_examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!