Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpr labs #53

Merged
merged 6 commits into from
Jun 28, 2017
Merged

gpr labs #53

merged 6 commits into from
Jun 28, 2017

Conversation

dccowan
Copy link
Member

@dccowan dccowan commented Jun 28, 2017

No description provided.

@@ -7,13 +7,25 @@
except Exception, e:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dccowan : This is outdated.
Only do:
from ipywidgets import

}
],
"source": [
"ifield = interact(PrimaryFieldWidget, tinterp = (0, 80, 2), epsr = (1, 40, 1))"
"radargramImage = \"../figures/GPR/ubc_GPRcmp.png\"\n",
"PrimaryFieldWidget(radargramImage)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dccowan : Fix the window size (ax.set_xlim(), ax.set_ylim())
The window size change with the widget, which it should not as we are looking at 'fix' data

}
],
"source": [
"i = interact(PipeWidget, epsr = (0, 100, 1), h=(0.1, 2.0, 0.1), xc=(0., 40., 0.2), r=(0.1, 3, 0.1) )"
"radargramImage = \"../figures/GPR/ubc_GPRdata.png\"\n",
"PipeWidget(radargramImage)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dccowan : The figure is fairly small. We can make it bigger
try fig = plt.figure(figsize = (10,5))

}
],
"source": [
"i = interact(WallWidget, epsr = (0, 100, 1), h=(0.1, 2.0, 0.1), x1=(1, 35, 1), x2=(20, 40, 1) )"
"radargramImage = \"../figures/GPR/ubc_GPRdata.png\"\n",
"WallWidget(radargramImage)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, the figure is fairly small.

@thast
Copy link
Member

thast commented Jun 28, 2017

@dccowan : For parameters descriptions, it could be nice to highlight them as it is done in most em_examples.
ex:

  • epsrL: relative permittivity for a linear arrival (direct or refracted wave)

@dccowan dccowan merged commit 3b2fb4e into master Jun 28, 2017
@dccowan dccowan deleted the GPRlabs branch June 28, 2017 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants