Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEOS-9535 Update Oracle JDBC driver #4119

Merged
merged 1 commit into from
May 19, 2020

Conversation

mprins
Copy link
Member

@mprins mprins commented Mar 9, 2020

Upgrade the Oracle JDBC driver to the latest version hosted on Maven Central, add the "Oracle Free Use Terms and Conditions" (FUTC), remove the now defunct oracleDriver profile

see:

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for community modules):

  • There is a ticket in Jira describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[GEOS-XYZW] Title of the Jira ticket" (export to XML in Jira generates the message in this exact form)
  • The pull request contains changes related to a single objective. If multiple focuses cannot be avoided, each one is in its own commit and has a separate ticket describing it.
  • New unit tests have been added covering the changes
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks (QA checks results will be reported by travis-ci after opening this PR)
  • Commits changing the UI, existing user workflows, or adding new functionality, need to include documentation updates (screenshots, text)
  • Committs changing the REST API, or any configuration object, should check it the REST API docs (Swagger YAML files and classic documentation) need to be updated.

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mprins mprins force-pushed the GEOT-9535_update_oracle_driver branch 2 times, most recently from cec9303 to 7b11801 Compare March 12, 2020 14:55
@mprins mprins changed the title WIP GEOS-9535 update oracle driver WIP GEOS-9535 Update Oracle JDBC driver Mar 12, 2020
@mprins mprins force-pushed the GEOT-9535_update_oracle_driver branch 2 times, most recently from 9478a05 to 872ae42 Compare March 17, 2020 13:11
@jodygarnett
Copy link
Member

I am excited for the change, anything to make oracle easier.

This was discussed in today's meeting, noting the STRUCT --> OracleStruct change we are not going to be able to backport.

@mprins mprins force-pushed the GEOT-9535_update_oracle_driver branch from 3b767ee to 08b9aa9 Compare March 21, 2020 10:41
@mprins
Copy link
Member Author

mprins commented Mar 22, 2020

This was discussed in today's meeting, noting the STRUCT --> OracleStruct change we are not going to be able to backport.

I understand that for Geotoos there is a minor API change from a concrete class to the interface of that class, but I think for Geoserver this can be backported since basically the only functional change here is that the oracle driver is added to the extension

@mprins mprins force-pushed the GEOT-9535_update_oracle_driver branch 4 times, most recently from e925e8d to f475226 Compare March 22, 2020 15:01
@mprins mprins marked this pull request as ready for review March 22, 2020 15:01
@mprins mprins changed the title WIP GEOS-9535 Update Oracle JDBC driver GEOS-9535 Update Oracle JDBC driver Mar 22, 2020
@mprins
Copy link
Member Author

mprins commented Mar 23, 2020

I've sent in a new CLA for B3Partners

@mprins mprins force-pushed the GEOT-9535_update_oracle_driver branch from f475226 to 7523b0c Compare March 23, 2020 09:15
@mprins mprins force-pushed the GEOT-9535_update_oracle_driver branch from 7523b0c to 6818bc3 Compare April 15, 2020 08:01
Oracle released driver version 19.6.0.0
@mprins mprins force-pushed the GEOT-9535_update_oracle_driver branch from ebc5d97 to 1ae7bf7 Compare April 24, 2020 11:25
@aaime
Copy link
Member

aaime commented May 19, 2020

The GeoTools portion is all merged, this one should also be good to go, merging.

@aaime aaime merged commit 4c2c024 into geoserver:master May 19, 2020
@mprins mprins deleted the GEOT-9535_update_oracle_driver branch May 19, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants