-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEOT-6529 Update Oracle JDBC driver #2832
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
mprins
force-pushed
the
GEOT-6529_update_oracle_driver
branch
from
March 10, 2020 09:49
a5839b5
to
f9e479a
Compare
aaime
reviewed
Mar 10, 2020
mprins
force-pushed
the
GEOT-6529_update_oracle_driver
branch
from
March 12, 2020 13:51
02bce59
to
88726cd
Compare
mprins
changed the title
WIP GEOT-6529 initial steps to update oracle driver
WIP GEOT-6529 Update Oracle JDBC driver
Mar 12, 2020
mprins
force-pushed
the
GEOT-6529_update_oracle_driver
branch
4 times, most recently
from
March 17, 2020 12:32
b16fe7c
to
cc675f1
Compare
mprins
changed the title
WIP GEOT-6529 Update Oracle JDBC driver
GEOT-6529 Update Oracle JDBC driver
Mar 17, 2020
jodygarnett
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I note some upgrade instructions will be needed for the geotools manual.
modules/plugin/jdbc/jdbc-oracle/src/test/java/org/geotools/data/oracle/Oracle3DOnlineTest.java
Outdated
Show resolved
Hide resolved
mprins
force-pushed
the
GEOT-6529_update_oracle_driver
branch
2 times, most recently
from
March 19, 2020 09:38
28f9001
to
d1d7347
Compare
I've sent in a new CLA for B3Partners |
mprins
force-pushed
the
GEOT-6529_update_oracle_driver
branch
2 times, most recently
from
April 21, 2020 13:40
68fd4ad
to
8946eda
Compare
12 tasks
Also factor out all Oracle deprecations, notably any use of: - oracle.sql.STRUCT - oracle.sql.ARRAY - oracle.sql.StructDescriptor - oracle.sql.ArrayDescriptor Make sure to use the proper driver classname, which is `oracle.jdbc.OracleDriver`, as well as some javadoc fixes and some replacement of StringBuffer by StringBuilder for improved performance. Ignore `Oracle3DOnlineTest#testBBOX3DOutsideLine()` as even in plain SQL it seems to fail Add a note to use the proper oracle driver class name in the upgrade notes Remove no longer useful user instructions for getting the oracle driver
mprins
force-pushed
the
GEOT-6529_update_oracle_driver
branch
from
April 23, 2020 10:42
8946eda
to
75c042a
Compare
Merged, thanks! |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the Oracle JDBC driver to the latest version hosted on Maven Central, fix any deprecations caused by the driver upgrade.
Also factor out all Oracle deprecations, notably any use of:
oracle.sql.STRUCT
oracle.sql.ARRAY
oracle.sql.StructDescriptor
oracle.sql.ArrayDescriptor
Make sure to use the proper driver classname, which is
oracle.jdbc.OracleDriver
, as well as some javadoc fixes and some replacement ofStringBuffer
byStringBuilder
for improved performance.Ignore/Disable
Oracle3DOnlineTest#testBBOX3DOutsideLine()
as even in plain SQL it seems to failAdd a note to use the proper oracle driver class name in the upgrade notes
see GEOT-6529
Geoserver followup: geoserver/geoserver#4119
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for unsupported modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.