Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Lock (GSIP 106) #538

Merged
merged 3 commits into from Mar 20, 2014
Merged

Conversation

jodygarnett
Copy link
Member

Port of LockProvider from GWC integrated into ResourceStore API.

For more information see http://geoserver.org/display/GEOS/GSIP+106+-+Managed+File+API

@aaime
Copy link
Member

aaime commented Mar 17, 2014

Hi Jody, seems like a good start, just mind, the lock provider needs to be configurable, e.g., in a single node scenario you probably want the in memory one, in a multi-node scenario where all nodes are sharing the same data dir you'll need the file system based one, or maybe better a Hazelcast based one.

@jodygarnett
Copy link
Member Author

The lock provider is configurable, see application context xml file.

Only thing I did unusual is make an adapter so that GWC can make use of the GeoServer LockProvider. That way this single/multi-node configuration only has to happen once.

@aaime
Copy link
Member

aaime commented Mar 17, 2014

Hi Jody,
If you look at the GWC conf GUI in GeoServer you will see the lock mamager
can be configured via a drop down choice. That's what I mean by
configurable :-)

Cheers
Andrea
Il 17/mar/2014 21:58 "Jody Garnett" notifications@github.com ha scritto:

The lock provider is configurable, see application context xml file.

Only thing I did unusual is make an adapter so that GWC can make use of
the GeoServer LockProvider. That way this single/multi-node configuration
only has to happen once.

Reply to this email directly or view it on GitHubhttps://github.com//pull/538#issuecomment-37869263
.

@jodygarnett
Copy link
Member Author

ooh neat - I will give it a go.

Jody Garnett

On Tue, Mar 18, 2014 at 8:19 AM, Andrea Aime notifications@github.comwrote:

Hi Jody,
If you look at the GWC conf GUI in GeoServer you will see the lock mamager
can be configured via a drop down choice. That's what I mean by
configurable :-)

Cheers
Andrea
Il 17/mar/2014 21:58 "Jody Garnett" notifications@github.com ha scritto:

The lock provider is configurable, see application context xml file.

Only thing I did unusual is make an adapter so that GWC can make use of
the GeoServer LockProvider. That way this single/multi-node configuration
only has to happen once.

Reply to this email directly or view it on GitHub<
https://github.com/geoserver/geoserver/pull/538#issuecomment-37869263>

.

Reply to this email directly or view it on GitHubhttps://github.com//pull/538#issuecomment-37871740
.

@jodygarnett
Copy link
Member Author

Well that was a lot more work then expected. Pull request includes requested UI changes (and docs).

The lockProvider is currently provided "too late" in the game, since global settings need to be read first. I am going to view this as low risk since the content is only being read (not edited).

Note we cannot pull the same trick as logging (logging (which parses the file by hand during servlet init) as the beans are not available until spring is ready.

@aaime
Copy link
Member

aaime commented Mar 20, 2014

On Thu, Mar 20, 2014 at 3:53 PM, Jody Garnett notifications@github.comwrote:

Well that was a lot more work then expected. Pull request includes
requested UI changes (and docs).

Sorry about that, Wicket has a steep learning curve. Everybody loves it so
much :-)

The lockProvider is currently provided "too late" in the game, since
global settings need to be read first. I am going to view this as low risk
since the content is only being read (not edited).

Right, hopefully good enough.

Cheers
Andrea

Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK

for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


@jodygarnett jodygarnett merged commit 871c6d5 into geoserver:master Mar 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants