Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature grid do not work with Chrome > 70 #3405

Closed
1 of 4 tasks
offtherailz opened this issue Dec 12, 2018 · 0 comments · Fixed by #3438
Closed
1 of 4 tasks

Feature grid do not work with Chrome > 70 #3405

offtherailz opened this issue Dec 12, 2018 · 0 comments · Fixed by #3438

Comments

@offtherailz
Copy link
Member

offtherailz commented Dec 12, 2018

Description

Things that do not work

  • Horizontal scroll
  • When scroll sometimes the whole grid becomes white
  • When select from autocomplete, the selection is not applied.

In case of Bug (otherwise remove this paragraph)

Browser Affected
(use this site: https://www.whatsmybrowser.org/ for non expert users)

  • Internet Explorer
  • Chrome
  • Firefox
  • Safari

Browser Version Affected

  • 70.0.3538.67

Steps to reproduce

  • Open the feature grid for a layer that have enough auttributes to scroll horizontally

Expected Result

  • The feature grid scroll horizontally
  • Doing login and editing works

Current Result

  • Horizontal scroll do not work
  • When resizing the feature grid, sometimes the grid becames all white.
  • Editing autocomplete do not work
  • Editing single row sometimes fails

Other useful information (optional):

Probably we have to update to this fixes:
adazzle/react-data-grid#1346

Unfortunately the fix is applied to a new version that is not compatible with current mapstore. Trying to apply the fix to the current version (in node_modules folder) makes the scroll bar to appear.

So a possible strategy is to:

  • Test and verify that feature grid works with this fix,in all browsers.
  • Fork react-data-grid on github
  • Checkout to the current release commit
    ( unfortunately there is not a tag for this version, use the commit 03f0eb7a0587393b49fcd6e72721dd75fdfb086d that should be the 2.0.59 version)
  • Apply the fix and publish on npm ( something like @geosolutions-it/react-data-grid)
  • Change package.json package to our fixed version.
  • Propose the fix (not sure that version is maintained anymore)

An (better, but harder) alternative is to update to the latest version of the library (also react-data-grid-addons have to be updated).

@offtherailz offtherailz added this to the 2019.01.00 milestone Dec 12, 2018
@offtherailz offtherailz changed the title Feature grid do not work with Feature grid do not work with Chrome 70 Dec 12, 2018
@offtherailz offtherailz changed the title Feature grid do not work with Chrome 70 Feature grid do not work with Chrome > 70 Dec 12, 2018
offtherailz added a commit to offtherailz/MapStore2 that referenced this issue Jan 9, 2019
@chiaracurcio chiaracurcio self-assigned this Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants