Fix #3405. Updated react-data-grid to latest version #3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
mbarto
reviewed
Jan 9, 2019
| .scan((acc) => acc + 1, 0) | ||
| .map(scrollToTopCounter => ({scrollToTopCounter})) | ||
| .startWith({}), | ||
| (props, newProps) => ({ |
There was a problem hiding this comment.
I only see one Observable, why props and newProps?
There was a problem hiding this comment.
They are 2 observable merged into one. Maybe newProps is misleasing. Should i call it forceScrollProps?
There was a problem hiding this comment.
Yes, maybe, should make it more clear, thanks
mbarto
reviewed
Jan 9, 2019
mbarto
reviewed
Jan 9, 2019
use a better name for `scrollToTopCounter` props
mbarto
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue for horizontal scrolling has been fixed in the latest version (see issue).
I had also to port some extension to the latest version:
immutabledependency (it doesn't work without)Gridobject has been changed and the old overrides that implemented this didn't work anymore. Implemented instead aforceScrollTopenhancer +scrollToTopCounterproperty to use to force scroll.RowRendererhave to userenderBaseRowto preservereffunction and so support frozen (ex - blocked) columns (tipically selection column and "zoom to feature" button in the feature grid). Otherwise the frozen columns didn't worked anymireIssues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
Grid can not be scrolled horizontally
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
I suggest to re-do all the integration tests on the feature grid.