modified renderButtons() in drawer/Menu.jsx (issue 1526)

[diegosanmartino]

config's ex:
"name": "Measure",
"override": {
"DrawerMenu": {
"buttonConfig": {
"tooltip": "Measure",
"buttonClassName": "square-button no-border"
},
"glyph": "1-stilo",
"position": 4
}
}

[mbarto]

Please, don't do sideeffects, the map function on arrays returns an array, don't use it as a forEach.

Something more similar to this is preferrable:

return this.props.children.map((child) => {
    const button = (<Button key={child.props.eventKey} bsSize="large" className={(child.props.buttonConfig && child.props.buttonConfig.buttonClassName) ? child.props.buttonConfig.buttonClassName : "square-button"} onClick={this.props.onChoose.bind(null, child.props.eventKey)} bsStyle={this.props.activeKey === child.props.eventKey ? 'default' : 'primary'}>
                        {child.props.glyph ? <Glyphicon glyph={child.props.glyph} /> : child.props.icon}
                    </Button>);
    const tooltip = <Tooltip key={"tooltip." + child.props.eventKey} id={"tooltip." + child.props.eventKey}>{child.props.tooltip || ''}</Tooltip>;
    return child.props.tooltip ? (
        <OverlayTrigger placement={"top"} key={"overlay-trigger." + child.props.eventKey}
            overlay={tooltip}>
            {button}
        </OverlayTrigger>
    ) : button;
});

[diegosanmartino]

ok

[coveralls]

Coverage decreased (-0.03%) to 77.092% when pulling f718171 on diegosanmartino:1526 into 6f57ada on geosolutions-it:master.

[coveralls]

Coverage remained the same at 77.122% when pulling f441ee4 on diegosanmartino:1526 into 6f57ada on geosolutions-it:master.

[mbarto]

var Message = require('../../components/I18N/Message');

[mbarto]

const tooltip = <Tooltip key={"tooltip." + child.props.eventKey} id={"tooltip." + child.props.eventKey}><Message msgId={child.props.buttonConfig.tooltip}/></Tooltip>;

[mbarto]

bottom, if you put it at top, it's not visible (did you test it?)

[diegosanmartino]

const tooltip = <Tooltip key={"tooltip." + child.props.eventKey} id={"tooltip." + child.props.eventKey}>;

child.props.buttonConfig.tooltip is correct but the tooltip is empty

[mbarto]

Do you have the string in your translations file?

[diegosanmartino]

ok

[coveralls]

Coverage remained the same at 77.122% when pulling 7f4b130 on diegosanmartino:1526 into 6f57ada on geosolutions-it:master.

[MV88]

Hi @diegosanmartino I would suggest you to use the Atom editor (or Sublime) with the plugins suggested here https://geosolutions-it.github.io/MapStore2/developer-guide/building-and-developing (especially eslint) in order to see in the editor some syntax error. This would avoid to push commit that will fail the travis build. Thank you