Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeoPackage cannot write boolean fields [GEOT-5483][GEOS-7654] #1272

Merged
merged 29 commits into from
Sep 16, 2016
Merged

GeoPackage cannot write boolean fields [GEOT-5483][GEOS-7654] #1272

merged 29 commits into from
Sep 16, 2016

Conversation

ianturton
Copy link
Member

@ianturton ianturton commented Aug 5, 2016 •
edited
Loading

Some work to make online tests work for GeoPackage.
Includes a fix for GEOT-5483 - GeoPackage cannot write boolean fields
Adds GeoPkgBooleanOnlineTest* implementations.
Adds a Boolean <-> Integer binding to allow reading of booleans.

@aaime
Copy link
Member

aaime commented Aug 5, 2016 •
edited
Loading

It's a bit hard to say what happened to GeoPackage, there is a lot of reformats. Looks like it happened in the "make online tests work" commit.

@bencaradocdavies
Copy link
Member

Jenkins CI has been having some problems so I restarted this build.

@bencaradocdavies
Copy link
Member

@ianturton looks like a genuine compile failure this time (Travis CI silliness has relented):

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project gt-geopkg: Compilation failure: Compilation failure:
[ERROR] /home/travis/build/geotools/geotools/modules/unsupported/geopkg/src/test/java/org/geotools/geopkg/GeoPkgFeatureSourceOnlineTest.java:[57,24] error: featureSource is not public in JDBCFeatureSourceOnlineTest; cannot be accessed from outside package
[ERROR] /home/travis/build/geotools/geotools/modules/unsupported/geopkg/src/test/java/org/geotools/geopkg/GeoPkgFeatureSourceOnlineTest.java:[58,24] error: featureSource is not public in JDBCFeatureSourceOnlineTest; cannot be accessed

aaime
aaime reviewed Aug 29, 2016
View reviewed changes
modules/unsupported/geopkg/src/main/java/org/geotools/geopkg/GeoPackage.java
throws IOException {
public static void addCRS(Connection cx, int srid, String srsName, String organization,
int organizationCoordSysId, String definition, String description) throws IOException {
// try {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover commented out section (there are others around here)

@ianturton ianturton self-assigned this Sep 9, 2016
@aaime
Copy link
Member

aaime commented Sep 16, 2016

Thanks Ian, merging!

@aaime aaime merged commit c318259 into geotools:master Sep 16, 2016
@aaime
Copy link
Member

aaime commented Sep 16, 2016

@ianturton can you close the tickets that all these commits solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ianturton ianturton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ianturton @aaime @bencaradocdavies