-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KatzCentrality plugin. #231
Conversation
Hi @yossisp I would like to propose some changes to your PR in light of the recent Gephi upgrades. In this PR, could you enable my contributions please, via https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork Thank you! |
Hi @mbastian, sure no problem, I see that "Allow edits by maintainer" checkbox is checked, please let me know if you have any issues adding your commits. |
Thanks @yossisp! Unfortunately it seems that your branch is a fork from |
Ah also, I don't know if you had a chance to look at the alternative implementation on this other PR: #186 Your implementation relies on Matrices while this other doesn't. I'm afraid matrices would take a lot of memory but it might be faster. |
Thanks @mbastian ! I used the katz centrality nbm file from the branch you created and it seems fine, but I also want to check with the university I developed the plugin for that they also confirm everything works as expected. Will update you as soon as I get their feedback. The only thing is that I get an error when running the plugin via |
I remember I saw this pr however I'm not sure it even works. Its author didn't respond since 2019. As far as I know the plugin I developed is used by the university which ordered this development and is not causing any memory issues. |
Thanks @yossisp I merged manually from the If you want to make some changes, you can do that directly from that branch instead of your fork. |
@mbastian Thanks for publishing! I have a few questions:
|
The
Yes, you can fix this by changing this line. Make sure to also increment your plugin version otherwise changes are not taken in account.
You use relative paths in your README. Change that to absolute paths and it should work. |
The plugin adds Katz Centrality calculation in Statistics module.