Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward incompatible changes introduced between 1.0.0 and 1.0.1 #9

Closed
bclodius opened this issue Sep 9, 2019 · 3 comments
Closed

Comments

@bclodius
Copy link

bclodius commented Sep 9, 2019

@gera2ld first of all shame on me for not doing pip freeze for my project dependencies; but wanted to report this for your awareness and in case anyone else is using this project.

Changes introduced here:

return res, from_cache
to return multiple values can cause conflicts where code expects this function to only return a single value.

My sample code

...
answer = await resolver.query(hostname, types.A)
ip_addresses = [result.data for result in answer.an if result.qtype == 1]
...

Exception I was facing

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'tuple' object has no attribute 'an'

To remediate this I updated my requirements.txt to have async_dns==1.0.0

@gera2ld
Copy link
Owner

gera2ld commented Sep 11, 2019

Sorry for the trouble, I didn't expect that there were dependents already.
I'll change the API to what it looked before to keep it consistent.

@gera2ld
Copy link
Owner

gera2ld commented Sep 11, 2019

fixed in 1.0.4

@gera2ld gera2ld closed this as completed Sep 11, 2019
@bclodius
Copy link
Author

thanks @gera2ld !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants