Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSES: Add dates for 2023 #264

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Conversation

philiptromans
Copy link

This PR adds Singapore Stock Exchange (XSES) holidays for 2023. This page states that there is no half day trading in 2023, and that holidays are taken from this page on the Ministry of Manpower's website.

Workflow to modify an existing Exchange Calendar

  • Modify calendar class as required.
  • Modify the test resources file (e.g tests/resources/{Exchange MIC}.csv), either manually or by executing python etc/make_exchange_calendar_test_csv.py {Exchange MIC}.
  • Check if any of the fixtures in tests/test_{Exchange MIC}_calendar.py need updating to reflect your changes.
  • Add references to any new/modified holidays in exchange_calendars/exchange_calendar_{Exchange MIC}.py.

@gerrymanoim gerrymanoim merged commit e976713 into gerrymanoim:master Dec 1, 2022
@gerrymanoim
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants