Fix possible crash at removing invalid creatureEvents (otland#4673)

correction of the loop
gesior · May 7, 2024 · 098ed9c · 098ed9c
1 parent a577601
commit 098ed9c
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/creatureevent.cpp b/src/creatureevent.cpp
@@ -23,9 +23,11 @@ void CreatureEvents::clear(bool fromLua)
 
 void CreatureEvents::removeInvalidEvents()
 {
-	for (auto it = creatureEvents.begin(); it != creatureEvents.end(); ++it) {
+	for (auto it = creatureEvents.begin(); it != creatureEvents.end();) {
 		if (it->second.getScriptId() == 0) {
-			creatureEvents.erase(it->second.getName());
+			it = creatureEvents.erase(it);
+		} else {
+			++it;
 		}
 	}
 }