Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: organization of files #24

Closed
chainsawriot opened this issue Jun 14, 2020 · 0 comments
Closed

Refactoring: organization of files #24

chainsawriot opened this issue Jun 14, 2020 · 0 comments

Comments

@chainsawriot
Copy link
Collaborator

chainsawriot commented Jun 14, 2020 •
edited
Loading

Previous refactoring (#18) has separated the logics for each topic model into its individual S3 method e.g. .extract_ingredients.input_model_s3_topicmodels. It would be better to extract them from oolong_tm.R and make them individual files, e.g. oolong_stm.R, so that if the support for stm doesn't work, we can know where to look and simply work on the oolong_stm.R file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chainsawriot