chore(channel offer): Reject a dlc channel offer if the processing fails #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ils. Unlike rejecting a dlc channel offer if accepting fails, the `Channel::Offered` and `Contract::Offered` have not been stored to the dlc store. Hence, there is no rust-dlc state to be cleaned up. Howerver, `rust-dlc` expects the `Channel::Offered` to be found by it's `dlc_channel_id`, which if it can't will fail the function. This patch implements the reject soly on the application layer, but we might want to consider moving that code to rust-dlc`
The same logic applies for a failed `SettleOffer` and `RenewOffer`
luckysori
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike rejecting a dlc channel offer if accepting fails, the
Channel::OfferedandContract::Offeredhave not been stored to the dlc store.Hence, there is no
rust-dlcstate to be cleaned up. However,rust-dlcexpects theChannel::Offeredto be found by it'sdlc_channel_id, which if it can't will fail the function.This patch implements the reject only on the application layer, but we might want to consider moving that code to
rust-dlcPrevents users from running into bugs like this #2131 to end up in a stuck state.