fix: Compute payout is greater than total collateral #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holzeis
changed the title
luckysori
force-pushed
the
fix/computed-payout-is-greater-than-total-collateral
branch
from
faed5e8
to
106f5cd
Compare
luckysori
approved these changes
Mar 23, 2023
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 23, 2023
319: fix: Compute payout is greater than total collateral r=luckysori a=holzeis Resolves #289. Resolves #306. The `rust-dlc` [branch](p2pderivatives/rust-dlc#97) that we depend on has already been rebased onto `master`, so we can fix the bug like this. Co-authored-by: Lucas Soriano del Pino <lucas_soriano@fastmail.com>
|
Build failed: |
luckysori
force-pushed
the
fix/computed-payout-is-greater-than-total-collateral
branch
from
106f5cd
to
e6ec260
Compare
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Mar 23, 2023
319: fix: Compute payout is greater than total collateral r=luckysori a=holzeis Resolves #289. Resolves #306. The `rust-dlc` [branch](p2pderivatives/rust-dlc#97) that we depend on has already been rebased onto `master`, so we can fix the bug like this. Co-authored-by: Lucas Soriano del Pino <lucas_soriano@fastmail.com>
|
Build failed: |
|
@luckysori why don't we just take the one commit that fixes the issue referenced in this PR instead of adding up multiple things here? |
To fix bug where generated payout was greater than total collateral.
luckysori
force-pushed
the
fix/computed-payout-is-greater-than-total-collateral
branch
from
e6ec260
to
766368e
Compare
|
bors r+ |
|
Build succeeded: |
bors
bot
deleted the
fix/computed-payout-is-greater-than-total-collateral
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #289.
Resolves #306.
The
rust-dlcbranch that we depend on has already been rebased ontomaster, so we can fix the bug like this.